From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752393AbbCJClX (ORCPT ); Mon, 9 Mar 2015 22:41:23 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:43806 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751295AbbCJClV (ORCPT ); Mon, 9 Mar 2015 22:41:21 -0400 Date: Mon, 09 Mar 2015 22:41:18 -0400 (EDT) Message-Id: <20150309.224118.1760532839925378471.davem@davemloft.net> To: arnd@arndb.de Cc: chien.yen@oracle.com, rds-devel@oss.oracle.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, roland@purestorage.com, sowmini.varadhan@oracle.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] rds: avoid potential stack overflow From: David Miller In-Reply-To: <17806664.ym3oszzFIH@wuerfel> References: <17806664.ym3oszzFIH@wuerfel> X-Mailer: Mew version 6.6 on Emacs 24.4 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann Date: Mon, 09 Mar 2015 13:06:52 +0100 > The rds_iw_add_conn function stores a large 'struct rds_sock' object > on the stack in order to pass a pair of addresses. As Sowmini pointed out, this function is not the top-level guilty one, it's rds_iw_update_cm_id. Please respin this with a corrected commit message, thanks.