From: Jiri Olsa <jolsa@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: acme@kernel.org, linux-kernel@vger.kernel.org,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH 3/4] perf, tools, stat: Fix IPC and other formulas with -A
Date: Mon, 9 Mar 2015 09:11:58 +0100 [thread overview]
Message-ID: <20150309081158.GC27885@krava.brq.redhat.com> (raw)
In-Reply-To: <1425858924-31414-4-git-send-email-andi@firstfloor.org>
On Sun, Mar 08, 2015 at 04:55:23PM -0700, Andi Kleen wrote:
SNIP
> - update_stats(&runtime_dtlb_cache_stats[ctx][0], count[0]);
> + update_stats(&runtime_dtlb_cache_stats[ctx][cpu], count[0]);
> else if (perf_evsel__match(counter, HW_CACHE, HW_CACHE_ITLB))
> - update_stats(&runtime_itlb_cache_stats[ctx][0], count[0]);
> + update_stats(&runtime_itlb_cache_stats[ctx][cpu], count[0]);
> }
>
> static void zero_per_pkg(struct perf_evsel *counter)
> @@ -463,7 +464,8 @@ static int read_cb(struct perf_evsel *evsel, int cpu, int thread __maybe_unused,
> perf_evsel__compute_deltas(evsel, cpu, count);
> perf_counts_values__scale(count, scale, NULL);
> evsel->counts->cpu[cpu] = *count;
> - update_shadow_stats(evsel, count->values);
> + if (aggr_mode == AGGR_NONE)
> + update_shadow_stats(evsel, count->values, cpu);
this will also prevent the 'socket' and 'core' aggregation
not to print bogus data for socket/core cpu 0, we'll need
to aggregate shadow stats first to support that.. anyway:
Acked-by: Jiri Olsa <jolsa@kernel.org>
thanks,
jirka
next prev parent reply other threads:[~2015-03-09 8:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-08 23:55 A number of perf stat improvements Andi Kleen
2015-03-08 23:55 ` [PATCH 1/4] perf, tools: Output running time and run/enabled ratio in CSV mode Andi Kleen
2015-03-09 7:49 ` Jiri Olsa
2015-03-09 14:04 ` Andi Kleen
2015-03-10 7:15 ` Namhyung Kim
2015-03-10 15:37 ` Andi Kleen
2015-03-11 0:52 ` Namhyung Kim
2015-03-08 23:55 ` [PATCH 2/4] perf, tools: Fix metrics calculation with event qualifiers Andi Kleen
2015-03-09 7:55 ` Jiri Olsa
2015-03-08 23:55 ` [PATCH 3/4] perf, tools, stat: Fix IPC and other formulas with -A Andi Kleen
2015-03-09 8:11 ` Jiri Olsa [this message]
2015-03-08 23:55 ` [PATCH 4/4] perf, tools, stat: Always correctly indent ratio column Andi Kleen
2015-03-09 8:24 ` Jiri Olsa
2015-03-11 13:35 ` A number of perf stat improvements Arnaldo Carvalho de Melo
2015-03-11 15:29 ` Andi Kleen
2015-03-11 19:13 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150309081158.GC27885@krava.brq.redhat.com \
--to=jolsa@redhat.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome