From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753073AbbCIMzQ (ORCPT ); Mon, 9 Mar 2015 08:55:16 -0400 Received: from mail-pd0-f178.google.com ([209.85.192.178]:34764 "EHLO mail-pd0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751205AbbCIMzK (ORCPT ); Mon, 9 Mar 2015 08:55:10 -0400 Date: Mon, 9 Mar 2015 18:25:03 +0530 From: Sudip Mukherjee To: Dan Carpenter Cc: Greg Kroah-Hartman , devel@driverdev.osuosl.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 4/4] staging: sm750fb: fix undeclared function Message-ID: <20150309125503.GB11724@sudip-PC> References: <1425886506-8643-1-git-send-email-sudipm.mukherjee@gmail.com> <1425886506-8643-4-git-send-email-sudipm.mukherjee@gmail.com> <20150309124222.GE10964@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150309124222.GE10964@mwanda> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 09, 2015 at 03:42:22PM +0300, Dan Carpenter wrote: > On Mon, Mar 09, 2015 at 01:05:06PM +0530, Sudip Mukherjee wrote: > > kbuild test robot reported that for microblaze-allyesconfig > > chan_to_field() and lynxfb_ops_set_par() were not defined. These two > > functions were defined under CONFIG_PM, so for any archtecture if > > CONFIG_PM is not defined we will have this error. > > > > while moving the lynxfb_suspend() function some very obvious > > checkpatch errors, like space after comma, space after if, space > > before opening brace, were taken care of. > > I have a script to review patches moving functions around but these > white space changes break my script so I have to review it by hand. > Sucks. oops . sorry .. > > > static int lynxfb_ops_set_par(struct fb_info * info) > > static inline unsigned int chan_to_field(unsigned int chan,struct fb_bitfield * bf) > > { > > chan &= 0xffff; > > These white space changes are not related. if you want i can break it into multiple patches, so that reviewing can be easy and your script will not break :) . Actually I thought, since this is a vendor crude driver there will be many such changes, so if i can combine some changes together then atleast the number of patches can be kept low and also i thought of clubbing these changes together as Joe Perches once told me "Don't get carried away with patch type separation" (reference: https://lkml.org/lkml/2015/1/1/2). regards sudip > > regards, > dan carpenter >