From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754439AbbCIOEi (ORCPT ); Mon, 9 Mar 2015 10:04:38 -0400 Received: from mga14.intel.com ([192.55.52.115]:19881 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753869AbbCIOEg (ORCPT ); Mon, 9 Mar 2015 10:04:36 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,368,1422950400"; d="scan'208";a="689189663" Date: Mon, 9 Mar 2015 07:04:34 -0700 From: Andi Kleen To: Jiri Olsa Cc: Andi Kleen , acme@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] perf, tools: Output running time and run/enabled ratio in CSV mode Message-ID: <20150309140434.GG31334@tassilo.jf.intel.com> References: <1425858924-31414-1-git-send-email-andi@firstfloor.org> <1425858924-31414-2-git-send-email-andi@firstfloor.org> <20150309074954.GA27885@krava.brq.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150309074954.GA27885@krava.brq.redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > hum, so people using CSV mode will now see extra 2 numbers > at the end of the line: > > $ ./perf.old stat -x, -e cycles ls > /dev/null > 2679161,,cycles > $ ./perf stat -x, -e cycles ls > /dev/null > 2574169,,cycles,1295544,100.00 > > we could be breaking existing scripts.. I doubt it. Typical CSV parsers ignore additional data at the end. Just don't insert stuff in the middle (like it was done recently). That breaks a lot of things. > you recently added 'running-time' option for record, > could you please add same option for stat? Could be done, but I'm not sure it's worth it here. -Andi