From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: full no_hz: how works arch_irq_work_raise() with tick off on generic implementation
Date: Mon, 9 Mar 2015 15:09:17 +0100 [thread overview]
Message-ID: <20150309140917.GB13768@linutronix.de> (raw)
I just stumbled over this in -RT. The code:
87 bool irq_work_queue(struct irq_work *work)
88 {
…
96 /* If the work is "lazy", handle it from next tick if any */
97 if (work->flags & IRQ_WORK_LAZY) {
98 if (llist_add(&work->llnode, this_cpu_ptr(&lazy_list)) &&
99 tick_nohz_tick_stopped())
100 arch_irq_work_raise();
101 } else {
102 if (llist_add(&work->llnode, this_cpu_ptr(&raised_list)))
103 arch_irq_work_raise();
104 }
…
109 }
so what I asked myself: What happens if the CPU is in NO_HZ mode with
the tick off and you invoke arch_irq_work_raise() on an architecture
without a special IRQ_WORK interrupt?
And why you don't this tick_nohz_tick_stopped() check for the
raised_list?
Wouldn't it be a easier for your full NO_HZ code to simply run in the
hardirq exit path instead of using irq_work?
Sebastian
next reply other threads:[~2015-03-09 14:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-09 14:09 Sebastian Andrzej Siewior [this message]
2015-03-09 15:09 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150309140917.GB13768@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®