From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754303AbbCISkr (ORCPT ); Mon, 9 Mar 2015 14:40:47 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:60886 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751011AbbCISkl (ORCPT ); Mon, 9 Mar 2015 14:40:41 -0400 Date: Mon, 9 Mar 2015 18:40:35 +0000 From: Mark Brown To: Adrian Remonda Cc: corbet@lwn.net, linux-spi@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Message-ID: <20150309184035.GZ28806@sirena.org.uk> References: <1425750995-18176-1-git-send-email-adrianremonda@gmail.com> <1425750995-18176-2-git-send-email-adrianremonda@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="+7aqSd/VAgMzTgew" Content-Disposition: inline In-Reply-To: <1425750995-18176-2-git-send-email-adrianremonda@gmail.com> X-Cookie: Editing is a rewording activity. User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 1/4] Cleaned hexadecimal dump X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --+7aqSd/VAgMzTgew Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sat, Mar 07, 2015 at 12:56:32PM -0500, Adrian Remonda wrote: > +static void hexDump(const void *src, size_t length, size_t bLine, char *prefix) > +{ Please call this hex_dump or something - that's more in line with the kernel coding style. Please also don't vUse aHungarian nNotation, it's also not the kernel coding style. --+7aqSd/VAgMzTgew Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJU/ekjAAoJECTWi3JdVIfQ5SUH/1uzQay0vUfnzUtfYC7AnZ6e T7U+Kxq9HY/3t++jeM0/wmlIMdG7gmYPy0TiAd1ePwjbVRzr6/WDXoYX3sQuHvup OY65Jt6FP/aCAyrqmsO5PGW6bdEF09GsMJ5tXN2VlUVyGn6sC5aPnrzUQ1AcX5Wa ptW6T/CZ4k2gklDPnSyfXdVnxDRGyg1YBFGtFE6elGvo7m3+5Ugo1/fhAFlQZUrb 2NdGiMNaEjoKHHIZ5r/8NW0qw2GZZCpI7eGQ0tsXSXOIHgHLGWDE3zxNPpaYQWwG OXvol4o4FmkT8oYoYhJHVGg3a9dcf0i/WJ9KzC3jr8O+kck9e45SL4eJ08FvYrQ= =3nNt -----END PGP SIGNATURE----- --+7aqSd/VAgMzTgew--