From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753737AbbCITly (ORCPT ); Mon, 9 Mar 2015 15:41:54 -0400 Received: from fieldses.org ([173.255.197.46]:59897 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752934AbbCITlw (ORCPT ); Mon, 9 Mar 2015 15:41:52 -0400 Date: Mon, 9 Mar 2015 15:41:51 -0400 From: "J. Bruce Fields" To: Al Viro Cc: Linus Torvalds , Linux Kernel Mailing List Subject: Re: [PATCH] sunrpc: fix braino in ->poll() Message-ID: <20150309194151.GB2627@fieldses.org> References: <20150305154921.GZ29656@ZenIV.linux.org.uk> <20150307204405.GC29656@ZenIV.linux.org.uk> <20150307210846.GF29656@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150307210846.GF29656@ZenIV.linux.org.uk> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Mar 07, 2015 at 09:08:46PM +0000, Al Viro wrote: > POLL_OUT isn't what callers of ->poll() are expecting to see; it's > actually __SI_POLL | 2 and it's a siginfo code, not a poll bitmap > bit... Thanks!--b. > > Signed-off-by: Al Viro > --- > diff --git a/net/sunrpc/cache.c b/net/sunrpc/cache.c > index 33fb105..5199bb1 100644 > --- a/net/sunrpc/cache.c > +++ b/net/sunrpc/cache.c > @@ -921,7 +921,7 @@ static unsigned int cache_poll(struct file *filp, poll_table *wait, > poll_wait(filp, &queue_wait, wait); > > /* alway allow write */ > - mask = POLL_OUT | POLLWRNORM; > + mask = POLLOUT | POLLWRNORM; > > if (!rp) > return mask;