From: Tejun Heo <tj@kernel.org>
To: Austin S Hemmelgarn <ahferroin7@gmail.com>
Cc: Aleksa Sarai <cyphar@cyphar.com>,
lizefan@huawei.com, mingo@redhat.com, peterz@infradead.org,
richard@nod.at, fweisbec@gmail.com, linux-kernel@vger.kernel.org,
cgroups@vger.kernel.org
Subject: Re: [PATCH v4 2/2] cgroups: add a pids subsystem
Date: Mon, 9 Mar 2015 15:51:17 -0400 [thread overview]
Message-ID: <20150309195117.GW13283@htj.duckdns.org> (raw)
In-Reply-To: <54FDED43.4050908@gmail.com>
Hello, Austin.
On Mon, Mar 09, 2015 at 02:58:11PM -0400, Austin S Hemmelgarn wrote:
> On 2015-03-08 23:34, Tejun Heo wrote:
> >
> >Does pids limit make sense in the root cgroup?
> >
> I would say it kind of does, although I would just expect it to track
> /proc/sys/kernel/pid_max (either as a read-only value, or as an alternative
> way to set it).
I don't think that's a good idea. It doesn't add anything while
putting pids controller in conflict with how other controllers handle
the root cgroup. Furthermore, I don't think it's generally a good
idea to add things because it may help convenience in some cases,
which is exactly the case here. Why add non-orthogonal component when
the only reason is "yeah, it may be a bit more convenient in some
imaginary cases"? We'd be restricting the design space we can move
inside for no good reason.
Thanks.
--
tejun
next prev parent reply other threads:[~2015-03-09 19:51 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-23 3:08 [PATCH RFC 0/2] add nproc cgroup subsystem Aleksa Sarai
2015-02-23 3:08 ` [PATCH RFC 1/2] cgroups: allow a cgroup subsystem to reject a fork Aleksa Sarai
2015-02-23 14:49 ` Peter Zijlstra
2015-02-23 3:08 ` [PATCH RFC 2/2] cgroups: add an nproc subsystem Aleksa Sarai
2015-02-27 4:17 ` [RFC PATCH v2 0/2] add nproc cgroup subsystem Aleksa Sarai
2015-02-27 4:17 ` [PATCH v2 1/2] cgroups: allow a cgroup subsystem to reject a fork Aleksa Sarai
2015-03-09 3:06 ` Tejun Heo
[not found] ` <CAOviyaip7Faz98YWzGoTaXGYVb72sfD+ZL4Xa89reU9+=43jFA@mail.gmail.com>
[not found] ` <20150309065902.GP13283@htj.duckdns.org>
2015-03-10 8:19 ` Aleksa Sarai
2015-03-10 12:47 ` Tejun Heo
2015-03-10 14:51 ` Aleksa Sarai
2015-03-10 15:17 ` Tejun Heo
2015-03-11 5:16 ` Aleksa Sarai
2015-03-11 11:46 ` Tejun Heo
2015-03-11 23:47 ` Aleksa Sarai
2015-03-12 1:25 ` Tejun Heo
2015-02-27 4:17 ` [PATCH v2 2/2] cgroups: add an nproc subsystem Aleksa Sarai
2015-03-02 15:22 ` Tejun Heo
2015-03-09 1:49 ` Zefan Li
2015-03-09 2:34 ` Tejun Heo
2015-02-27 11:49 ` [PATCH RFC 0/2] add nproc cgroup subsystem Tejun Heo
2015-02-27 13:46 ` Richard Weinberger
2015-02-27 13:52 ` Tejun Heo
2015-02-27 16:42 ` Austin S Hemmelgarn
2015-02-27 17:06 ` Tejun Heo
2015-02-27 17:25 ` Tim Hockin
2015-02-27 17:45 ` Tejun Heo
2015-02-27 17:56 ` Tejun Heo
2015-02-27 21:45 ` Tim Hockin
2015-02-27 21:49 ` Tejun Heo
[not found] ` <CAAAKZwsCc8BtFx58KMFpRTohU81oCBeGVOPGMJrjJt9q5upKfQ@mail.gmail.com>
2015-02-28 16:57 ` Tejun Heo
2015-02-28 22:26 ` Tim Hockin
2015-02-28 22:50 ` Tejun Heo
2015-03-01 4:46 ` Tim Hockin
2015-02-28 23:11 ` Johannes Weiner
2015-02-27 18:49 ` Austin S Hemmelgarn
2015-02-27 19:35 ` Tejun Heo
2015-02-28 9:26 ` Aleksa Sarai
2015-02-28 11:59 ` Tejun Heo
[not found] ` <CAAAKZws45c3PhFQMGrm_K+OZV+KOyGV9sXTakHcTfNP1kHxzOQ@mail.gmail.com>
2015-02-28 16:43 ` Tejun Heo
2015-03-02 13:13 ` Austin S Hemmelgarn
2015-03-02 13:31 ` Aleksa Sarai
2015-03-02 13:54 ` Tejun Heo
2015-03-02 13:49 ` Tejun Heo
2015-02-27 17:12 ` Tim Hockin
2015-02-27 17:15 ` Tejun Heo
2015-03-04 20:23 ` [PATCH v3 0/2] cgroup: add pids subsystem Aleksa Sarai
2015-03-04 20:23 ` [PATCH v3 1/2] cgroups: allow a cgroup subsystem to reject a fork Aleksa Sarai
2015-03-04 20:23 ` [PATCH v3 2/2] cgroups: add a pids subsystem Aleksa Sarai
2015-03-05 8:39 ` Aleksa Sarai
2015-03-05 14:37 ` Marian Marinov
2015-03-06 1:45 ` [PATCH v4 0/2] cgroup: add " Aleksa Sarai
2015-03-06 1:45 ` [PATCH v4 1/2] cgroups: allow a cgroup subsystem to reject a fork Aleksa Sarai
2015-03-06 1:45 ` [PATCH v4 2/2] cgroups: add a pids subsystem Aleksa Sarai
2015-03-09 3:34 ` Tejun Heo
2015-03-09 3:39 ` Tejun Heo
2015-03-09 18:58 ` Austin S Hemmelgarn
2015-03-09 19:51 ` Tejun Heo [this message]
2015-03-10 8:10 ` Aleksa Sarai
2015-03-10 11:32 ` Austin S Hemmelgarn
2015-03-10 12:31 ` Aleksa Sarai
2015-03-11 15:13 ` Austin S Hemmelgarn
2015-03-12 2:28 ` Aleksa Sarai
2015-03-12 15:35 ` Austin S Hemmelgarn
2015-03-12 3:47 ` Tejun Heo
2015-03-09 3:08 ` [PATCH v4 0/2] cgroup: add " Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150309195117.GW13283@htj.duckdns.org \
--to=tj@kernel.org \
--cc=ahferroin7@gmail.com \
--cc=cgroups@vger.kernel.org \
--cc=cyphar@cyphar.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®