From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753733AbbCIWSz (ORCPT ); Mon, 9 Mar 2015 18:18:55 -0400 Received: from metis.ext.pengutronix.de ([92.198.50.35]:34164 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753363AbbCIWSw (ORCPT ); Mon, 9 Mar 2015 18:18:52 -0400 Date: Mon, 9 Mar 2015 23:17:52 +0100 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Paul Bolle Cc: Maxime Coquelin , Andreas =?iso-8859-1?Q?F=E4rber?= , Geert Uytterhoeven , Rob Herring , Philipp Zabel , Jonathan Corbet , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Russell King , Daniel Lezcano , Thomas Gleixner , Linus Walleij , Greg Kroah-Hartman , Jiri Slaby , Arnd Bergmann , Andrew Morton , "David S. Miller" , Mauro Carvalho Chehab , Joe Perches , Antti Palosaari , Tejun Heo , Will Deacon , Nikolay Borisov , Rusty Russell , Kees Cook , Michal Marek , "linux-doc@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-gpio@vger.kernel.org" , "linux-serial@vger.kernel.org" , Linux-Arch , "linux-api@vger.kernel.org" Subject: Re: [PATCH v2 04/18] clocksource: Add ARM System timer driver Message-ID: <20150309221752.GE7525@pengutronix.de> References: <1424455277-29983-1-git-send-email-mcoquelin.stm32@gmail.com> <1424455277-29983-5-git-send-email-mcoquelin.stm32@gmail.com> <20150220195437.GT19388@pengutronix.de> <1424468908.24292.10.camel@x220> <1425411786.2606.24.camel@tiscali.nl> <1425935552.4244.6.camel@x220> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1425935552.4244.6.camel@x220> User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::7 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Mon, Mar 09, 2015 at 10:12:32PM +0100, Paul Bolle wrote: > On Wed, 2015-03-04 at 13:08 +0100, Maxime Coquelin wrote: > > This is because I added also support for COMPILE_TEST coverage as per > > Uwe advice, > > and thought it was necessary to have an entry for this. > > Maybe I'm just wrong? > > I missed that you added COMPILE_TEST. > > A quick scan of your idea doesn't show any obvious issues. (Note that I > don't really know how people actually use COMPILE_TEST. I guess things > like "make allyesconfig" are involved.) Maybe this can clearify the purpose of COMPILE_TEST: diff --git a/init/Kconfig b/init/Kconfig --- a/init/Kconfig +++ b/init/Kconfig @@ -67,6 +67,26 @@ config COMPILE_TEST here. If you are a user/distributor, say N here to exclude useless drivers to be distributed. + # If you are a driver author consider to adjust your driver's + # dependencies to make it buildable with minimal preconditions if + # COMPILE_TEST is enabled. This helps contributers and maintainers + # that might not have the necessary toolchain or kernel config handy and + # also increases compile test coverage. It's your advantage if others can + # build your driver more easily! So for a device that is only found on the + # foo cpu use: + # + # depends on CPU_FOO || COMPILE_TEST + # + # . You might have to use + # + # depends on CPU_FOO || (COMPILE_TEST && COOKIE) + # + # or + # + # depends on COOKIE && (CPU_FOO || COMPILE_TEST) + # + # if your driver uses features that are only available if COOKIE is on. + config LOCALVERSION string "Local version - append to kernel release" help -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |