From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752697AbbCJKq1 (ORCPT <rfc822;w@1wt.eu>);
	Tue, 10 Mar 2015 06:46:27 -0400
Received: from zimbra13.linbit.com ([212.69.166.240]:43077 "EHLO
	zimbra13.linbit.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752621AbbCJKqY (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 10 Mar 2015 06:46:24 -0400
X-Greylist: delayed 460 seconds by postgrey-1.27 at vger.kernel.org; Tue, 10 Mar 2015 06:46:23 EDT
Date: Tue, 10 Mar 2015 11:38:38 +0100
From: Lars Ellenberg <lars.ellenberg@linbit.com>
To: David Rientjes <rientjes@google.com>
Cc: Jens Axboe <axboe@fb.com>, drbd-dev@lists.linbit.com,
        linux-kernel@vger.kernel.org
Subject: Re: [DRBD-user] [patch 1/2] block, drbd: fix drbd_req_new()
 initialization
Message-ID: <20150310103838.GB3961@soda.linbit>
Mail-Followup-To: David Rientjes <rientjes@google.com>,
	Jens Axboe <axboe@fb.com>, drbd-dev@lists.linbit.com,
	linux-kernel@vger.kernel.org
References: <alpine.DEB.2.10.1503071623250.31688@chino.kir.corp.google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.10.1503071623250.31688@chino.kir.corp.google.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Mar 07, 2015 at 04:24:02PM -0800, David Rientjes wrote:
> mempool_alloc() does not support __GFP_ZERO since elements may come from
> memory that has already been released by mempool_free().
> 
> Remove __GFP_ZERO from mempool_alloc() in drbd_req_new() and properly
> initialize it to 0.

We used to have the explicit memset there,
but then changed that, because

I was under the impression that since
2007-07-17 d07dbea, Slab allocators: support __GFP_ZERO in all allocators
it was supported?

	Lars Ellenberg