From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
YH Chen <yh.chen@mediatek.com>,
linux-kernel@vger.kernel.org,
Henry Chen <henryc.chen@mediatek.com>,
Flora Fu <flora.fu@mediatek.com>,
linux-mediatek@lists.infradead.org, kernel@pengutronix.de,
Yingjoe Chen <Yingjoe.Chen@mediatek.com>,
Eddie Huang <eddie.huang@mediatek.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] soc: mediatek: Add PMIC wrapper for MT8135 and MT8173 SoCs
Date: Tue, 10 Mar 2015 15:46:11 +0000 [thread overview]
Message-ID: <20150310154610.GP8656@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1426000954-7647-3-git-send-email-s.hauer@pengutronix.de>
On Tue, Mar 10, 2015 at 04:22:34PM +0100, Sascha Hauer wrote:
> + for (i = 0; i < 4; i++) {
> + pwrap_writel(wrp, i, PWRAP_SIDLY);
> + pwrap_read(wrp, PWRAP_DEW_READ_TEST, &rdata);
> + printk("%s: 0x%04x\n", __func__, rdata);
Is this really ready for submission, or is this just a hidden oversight?
What I tend to do with such debugging is _not_ to indent it at all, which
means when the file is reviewed before sending it out (or indeed, when
diffing it to review the updates before committing those changes or an
amendment to the previous commit) that it sticks out like a sore thumb.
--
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2015-03-10 15:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-10 15:22 [PATCH v2] Mediatek PMIC wrapper support Sascha Hauer
2015-03-10 15:22 ` [PATCH 1/2] dt-bindings: ARM: Mediatek: document binding for the PMIC wrapper Sascha Hauer
2015-03-10 15:22 ` [PATCH 2/2] soc: mediatek: Add PMIC wrapper for MT8135 and MT8173 SoCs Sascha Hauer
2015-03-10 15:46 ` Russell King - ARM Linux [this message]
2015-03-10 16:10 ` Sascha Hauer
2015-03-11 11:12 ` Paul Bolle
2015-03-12 7:28 ` Sascha Hauer
2015-03-17 10:14 [PATCH v3] Mediatek PMIC wrapper support Sascha Hauer
2015-03-17 10:14 ` [PATCH 2/2] soc: mediatek: Add PMIC wrapper for MT8135 and MT8173 SoCs Sascha Hauer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150310154610.GP8656@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=Yingjoe.Chen@mediatek.com \
--cc=eddie.huang@mediatek.com \
--cc=flora.fu@mediatek.com \
--cc=henryc.chen@mediatek.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=s.hauer@pengutronix.de \
--cc=yh.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®