From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753334AbbCJTqe (ORCPT <rfc822;w@1wt.eu>);
	Tue, 10 Mar 2015 15:46:34 -0400
Received: from mga01.intel.com ([192.55.52.88]:18814 "EHLO mga01.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751423AbbCJTqc (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 10 Mar 2015 15:46:32 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.11,376,1422950400"; 
   d="scan'208";a="696737999"
Date: Tue, 10 Mar 2015 15:46:29 -0400
From: Matthew Wilcox <willy@wil.cx>
To: J Freyensee <james_p_freyensee@linux.intel.com>
Cc: Alexey Khoroshilov <khoroshilov@ispras.ru>,
        Matthew Wilcox <willy@linux.intel.com>,
        Keith Busch <keith.busch@intel.com>, ldv-project@linuxtesting.org,
        linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] NVMe: Fix error handling of class_create("nvme")
Message-ID: <20150310194629.GQ2780@wil.cx>
References: <1425681821-620-1-git-send-email-khoroshilov@ispras.ru>
 <1426015102.18746.10.camel@jpfreyen-mobl5.amr.corp.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1426015102.18746.10.camel@jpfreyen-mobl5.amr.corp.intel.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Mar 10, 2015 at 12:18:22PM -0700, J Freyensee wrote:
> Looking at IS_ERR(), it uses IS_ERR_VALUE() which uses unlikely(), which
> from what I understand is a compiler hint that means "this error is
> unlikely to happen".
> 
> Well, is this error unlikely to happen?  Looks like the error could be

Yes.  All errors are, by definition, unlikely to happen.