From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753107AbbCJVIi (ORCPT ); Tue, 10 Mar 2015 17:08:38 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:56375 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751057AbbCJVIf (ORCPT ); Tue, 10 Mar 2015 17:08:35 -0400 Date: Tue, 10 Mar 2015 16:07:54 -0500 From: Felipe Balbi To: Alan Stern CC: Al Viro , Alexander Holler , Richard Weinberger , USB list , LKML , Felipe Balbi Subject: Re: gadgetfs broken since 7f7f25e8 Message-ID: <20150310210754.GB25666@saruman.tx.rr.com> Reply-To: References: <20150308173836.GH29656@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="IrhDeMKUP4DT/M7F" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --IrhDeMKUP4DT/M7F Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Mar 08, 2015 at 02:35:25PM -0400, Alan Stern wrote: > On Sun, 8 Mar 2015, Al Viro wrote: >=20 > > On Sat, Mar 07, 2015 at 04:08:49PM -0500, Alan Stern wrote: > > > On Sat, 7 Mar 2015, Alexander Holler wrote: > > >=20 > > > > Am 07.03.2015 um 12:23 schrieb Alexander Holler: > > > > > Am 04.03.2015 um 16:31 schrieb Alan Stern: > > > > >=20 > > > > >> check to see what those values actually were. It's easy enough = to fix > > > > >> up, though; revised patch below. > > > > >=20 > > > > > Thanks, in contrast to the patch from Al Viro that one applies. > > > >=20 > > > > And as I've just tested it, it isn't complete. ep_config_operations= will > > > > be switched to ep_io_operations and suffers under the same problem = of > > > > not having initially (aio_)read/(aio_)write since commit 7f7f25e8 = (3.16). > > >=20 > > > Of course. I stated in the email accompanying the original version of > > > this patch that it contained some corrections that Al's patch left ou= t. =20 > > > You have to use the two of them together to fix all the issues. > >=20 > > FWIW, I've pushed those two fixes in vfs.git#gadget; could I have your > > s-o-b on the ep0 part? See 2b13438 in vfs.git... >=20 > Certainly. >=20 > Signed-off-by: Alan Stern Just to make sure people know I'm okay with you taking the patch: Acked-by: Felipe Balbi --=20 balbi --IrhDeMKUP4DT/M7F Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJU/10qAAoJEIaOsuA1yqRE6hwP/2fuPHGWgvE/7i3REpy3+2r2 r6TCdlvcEGEO8h068yhuqdnVVB4KGAGbKLJafDlsPbA/A8UHVzZUTsbT42SEtbiN Tyte037zvxDBiRyDi7ZPsVdZT2UjI3J3eskM7Y85VUp+GYPRRUynBkuQZRhtmzNi vgop/YjmA+kIkTuiMxmh0RsVXbwiG0S/CUhkRTFvKX+FP/ZPqTgSzdDoPw1qM2SJ qcXoyNz8Yz3e28hWYrJzzNozkIQZPMr45rwqqGFaK0dz+TQHB+W+WkQnxN5gvW77 WQPbZfzmjdTPBlj1Rfzkme+GzKS6SEBBIPBwZ6RecJA6ukH96aa/X0wFUr5ynj07 ihtixQOgOKslHg5Uok8e/dTYehytGbZgMQJgL/G9GvFg4d+lQFWjcjVC66LFPBUV asKgiIXorY/z0TgV2R7kWerSY9smUVYRhtGuATIr1Te5rTzz5RvborGarRpgJB/J M+OSvUYNjIZL6jkLJZ0B/Wl4WQPfkzVcqDrngJdZ51srupZ6ZxOmnyBkP543Z0hg HV6WYQ7rvM0vNh/bs1S/tjfSH6MCDVtVhyiAAS0VcT0yQU0mUqwOubfPkqbEneCO WAu+OTGvi5uMMFE23i9AC+sU/pXs12O3VrzKSxylyd/07MmKTCKqlkBkdXnCBqeD tizRLBLKQe2sklUB0uaW =6vaD -----END PGP SIGNATURE----- --IrhDeMKUP4DT/M7F--