From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753372AbbCJWhn (ORCPT ); Tue, 10 Mar 2015 18:37:43 -0400 Received: from mail.kapsi.fi ([217.30.184.167]:35094 "EHLO mail.kapsi.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752629AbbCJWhj (ORCPT ); Tue, 10 Mar 2015 18:37:39 -0400 Date: Wed, 11 Mar 2015 00:37:35 +0200 From: Mikko Rapeli To: Masahiro Yamada Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH 02/45] scripts/headers.sh: add verbose option to make calls if defined Message-ID: <20150310223735.GV12550@lakka.kapsi.fi> References: <1424127948-22484-1-git-send-email-mikko.rapeli@iki.fi> <1424127948-22484-3-git-send-email-mikko.rapeli@iki.fi> <20150217161859.A3BA.AA925319@jp.panasonic.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150217161859.A3BA.AA925319@jp.panasonic.com> X-SA-Exim-Connect-IP: 2001:1bc8:1004::1 X-SA-Exim-Mail-From: mikko.rapeli@iki.fi X-SA-Exim-Scanned: No (on mail.kapsi.fi); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 17, 2015 at 04:18:59PM +0900, Masahiro Yamada wrote: > > On Tue, 17 Feb 2015 00:05:05 +0100 > Mikko Rapeli wrote: > > > Useful when debugging the scripts. > > > > Signed-off-by: Mikko Rapeli > > --- > > scripts/headers.sh | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/scripts/headers.sh b/scripts/headers.sh > > index 95ece06..aa62fd8 100755 > > --- a/scripts/headers.sh > > +++ b/scripts/headers.sh > > @@ -7,7 +7,7 @@ set -e > > do_command() > > { > > if [ -f ${srctree}/arch/$2/include/asm/Kbuild ]; then > > - make ARCH=$2 KBUILD_HEADERS=$1 headers_$1 > > + make V=$KBUILD_VERBOSE ARCH=$2 KBUILD_HEADERS=$1 headers_$1 > > else > > printf "Ignoring arch: %s\n" ${arch} > > fi > > -- > > > KBUILD_VERBOSE is already exported. > > Why do you need to set V=... again here? You're right, I'll drop this too. Thanks for the review! -Mikko