From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753373AbbCJWow (ORCPT ); Tue, 10 Mar 2015 18:44:52 -0400 Received: from mail.kapsi.fi ([217.30.184.167]:60469 "EHLO mail.kapsi.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750920AbbCJWov (ORCPT ); Tue, 10 Mar 2015 18:44:51 -0400 Date: Wed, 11 Mar 2015 00:44:48 +0200 From: Mikko Rapeli To: Michal Marek Cc: linux-kernel@vger.kernel.org, Andrew Morton , Javier Barrio Subject: Re: [PATCH 03/45] headers_install.sh: enhance error handling Message-ID: <20150310224448.GW12550@lakka.kapsi.fi> References: <1424127948-22484-1-git-send-email-mikko.rapeli@iki.fi> <1424127948-22484-4-git-send-email-mikko.rapeli@iki.fi> <54E33F7F.8020201@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54E33F7F.8020201@suse.cz> X-SA-Exim-Connect-IP: 2001:1bc8:1004::1 X-SA-Exim-Mail-From: mikko.rapeli@iki.fi X-SA-Exim-Scanned: No (on mail.kapsi.fi); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 17, 2015 at 02:17:51PM +0100, Michal Marek wrote: > On 2015-02-17 00:05, Mikko Rapeli wrote: > > Exit with error if using undefined variables or if any sub command fails > > with error return value. unidef needs special handling since but this can > > be done without the trap. Enables exaniming intermediate files if some > > commands failed. > > The intermediate files are removed by your patch as well, aren't they? > Actually, I don't see any change in behavior after your patch. Yes, if everything succeeded without errors, then intermediate files are removed. But the files are left around if something fails which is what I like in scripts. -Mikko