From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750774AbbCJWsH (ORCPT ); Tue, 10 Mar 2015 18:48:07 -0400 Received: from mail.kapsi.fi ([217.30.184.167]:38836 "EHLO mail.kapsi.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750752AbbCJWsF (ORCPT ); Tue, 10 Mar 2015 18:48:05 -0400 Date: Wed, 11 Mar 2015 00:48:00 +0200 From: Mikko Rapeli To: Arnd Bergmann Cc: Alasdair G Kergon , linux-kernel@vger.kernel.org, Mike Snitzer , dm-devel@redhat.com, linux-api@vger.kernel.org Subject: Re: [PATCH 15/45] dm-log-userspace.h: include stdint.h in userspace Message-ID: <20150310224800.GX12550@lakka.kapsi.fi> References: <1424127948-22484-1-git-send-email-mikko.rapeli@iki.fi> <2309592.iOl8K3u7d8@wuerfel> <20150217133806.GA5220@agk-dp.fab.redhat.com> <2286739.alIuOL4vnt@wuerfel> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2286739.alIuOL4vnt@wuerfel> X-SA-Exim-Connect-IP: 2001:1bc8:1004::1 X-SA-Exim-Mail-From: mikko.rapeli@iki.fi X-SA-Exim-Scanned: No (on mail.kapsi.fi); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 17, 2015 at 02:55:49PM +0100, Arnd Bergmann wrote: > On Tuesday 17 February 2015 13:38:06 Alasdair G Kergon wrote: > > On Tue, Feb 17, 2015 at 10:08:56AM +0100, Arnd Bergmann wrote: > > > The normal way to do this in kernel headers is to use linux/types.h > > > but change the data structures to use __u64 instead of uint64_t > > > to avoid the build error. > > > > That's what happened to dm-ioctl.h. > > Ah, indeed. It turns out that it was my own change that did this: > > > commit 9adfbfb611307060db54691bc7e6d53fdc12312b > Author: Arnd Bergmann > Date: Thu Feb 26 00:51:40 2009 +0100 > > make most exported headers use strict integer types > > This takes care of all files that have only a small number > of non-strict integer type uses. > > > (Or someone could adjust linux/types.h to include these as standard.) > > No, that wouldn't work. The C user space headers are not meant to > be included implicitly by any standard headers, which might pull > in linux/types.h implicitly. > > I think it would be best to change all patches in the new series > in the same way for consistency and try to avoid using stdint.h > as much as we can. Ok, I'll change all patches to use __u8 etc types instead of uint8_t etc via stdint.h. -Mikko