From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751210AbbCJWs4 (ORCPT ); Tue, 10 Mar 2015 18:48:56 -0400 Received: from mail.kapsi.fi ([217.30.184.167]:39429 "EHLO mail.kapsi.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751076AbbCJWsy (ORCPT ); Tue, 10 Mar 2015 18:48:54 -0400 Date: Wed, 11 Mar 2015 00:48:49 +0200 From: Mikko Rapeli To: David Vrabel Cc: linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, xen-devel@lists.xenproject.org, Boris Ostrovsky Subject: Re: [Xen-devel] [PATCH 25/45] gntalloc.h: include stdint.h in userspace Message-ID: <20150310224849.GY12550@lakka.kapsi.fi> References: <1424127948-22484-1-git-send-email-mikko.rapeli@iki.fi> <1424127948-22484-26-git-send-email-mikko.rapeli@iki.fi> <54E47D32.9040208@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <54E47D32.9040208@citrix.com> X-SA-Exim-Connect-IP: 2001:1bc8:1004::1 X-SA-Exim-Mail-From: mikko.rapeli@iki.fi X-SA-Exim-Scanned: No (on mail.kapsi.fi); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 18, 2015 at 11:53:22AM +0000, David Vrabel wrote: > On 16/02/15 23:05, Mikko Rapeli wrote: > > Fixes compilation error: > > > > xen/gntalloc.h:22:2: error: unknown type name ‘uint16_t’ > > > > Signed-off-by: Mikko Rapeli > > --- > > include/uapi/xen/gntalloc.h | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/include/uapi/xen/gntalloc.h b/include/uapi/xen/gntalloc.h > > index 76bd580..184df7e 100644 > > --- a/include/uapi/xen/gntalloc.h > > +++ b/include/uapi/xen/gntalloc.h > > @@ -11,6 +11,12 @@ > > #ifndef __LINUX_PUBLIC_GNTALLOC_H__ > > #define __LINUX_PUBLIC_GNTALLOC_H__ > > > > +#ifdef __KERNEL__ > > +#include > > +#else > > +#include > > +#endif > > I think it would be preferrable to #include only and > switch to using the __u32 etc. types (as others have suggested). Yes, I'm changes the patches to these. -Mikko