From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752782AbbCKBWK (ORCPT ); Tue, 10 Mar 2015 21:22:10 -0400 Received: from mail.kapsi.fi ([217.30.184.167]:41816 "EHLO mail.kapsi.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751606AbbCKBWI (ORCPT ); Tue, 10 Mar 2015 21:22:08 -0400 Date: Wed, 11 Mar 2015 03:22:04 +0200 From: Mikko Rapeli To: Takashi Iwai Cc: linux-kernel@vger.kernel.org, Jaroslav Kysela , alsa-devel@alsa-project.org, linux-api@vger.kernel.org Subject: Re: [PATCH 41/45] include/uapi/sound/emu10k1.h: hide gpr_valid, tram_valid and code_valid in userspace Message-ID: <20150311012204.GE12550@lakka.kapsi.fi> References: <1424127948-22484-1-git-send-email-mikko.rapeli@iki.fi> <1424127948-22484-42-git-send-email-mikko.rapeli@iki.fi> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-SA-Exim-Connect-IP: 2001:1bc8:1004::1 X-SA-Exim-Mail-From: mikko.rapeli@iki.fi X-SA-Exim-Scanned: No (on mail.kapsi.fi); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 17, 2015 at 07:27:38AM +0100, Takashi Iwai wrote: > At Tue, 17 Feb 2015 00:05:44 +0100, > Mikko Rapeli wrote: > > > > The DECLARE_BITMAP macro is not available in userspace headers. > > Fixes userspace compile error: > > error: expected specifier-qualifier-list before ‘DECLARE_BITMAP’ > > It's nonsense. This results in an incompatible structure, thus ABI > would be broken completely (actually this will break the compile of > ld10k1). None of the exported headers after 'make headers_install' have definition of DECLARE_BITMAP macro. It is defined in include/linux/types.h which is different from include/uapi/linux/types.h and missing this definition and a few other things. One option would be add DECLARE_BITMAP macro to include/uapi/linux/types.h and add include/linux/bitops.h to uapi. Thoughts? -Mikko