From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751767AbbCKBt5 (ORCPT ); Tue, 10 Mar 2015 21:49:57 -0400 Received: from mail.kapsi.fi ([217.30.184.167]:45893 "EHLO mail.kapsi.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751259AbbCKBtz (ORCPT ); Tue, 10 Mar 2015 21:49:55 -0400 Date: Wed, 11 Mar 2015 03:49:53 +0200 From: Mikko Rapeli To: Jan Engelhardt Cc: Linux Kernel Mailing List , Netfilter Developer Mailing List , linux-api@vger.kernel.org Subject: Re: [PATCH 43/45] include/uapi/linux/netfilter_bridge.h: include if.h Message-ID: <20150311014952.GF12550@lakka.kapsi.fi> References: <1424127948-22484-1-git-send-email-mikko.rapeli@iki.fi> <1424127948-22484-44-git-send-email-mikko.rapeli@iki.fi> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-SA-Exim-Connect-IP: 2001:1bc8:1004::1 X-SA-Exim-Mail-From: mikko.rapeli@iki.fi X-SA-Exim-Scanned: No (on mail.kapsi.fi); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 17, 2015 at 01:02:50AM +0100, Jan Engelhardt wrote: > On Tuesday 2015-02-17 00:05, Mikko Rapeli wrote: > > >Fixes userspace compilation errors like: > > > >error: field ‘in’ has incomplete type > >struct in_addr in; > > > >+#include > > Patch 36/45 included linux/in.h instead of linux/if.h for addressing "in has incomplete > type". Should this be used here too? It could, yes. It seems I cut some corners since this was hiding behind it: In file included from ./linux/netfilter_bridge.h:11:0, from ./linux/netfilter_bridge.c:1: ./linux/if_pppox.h:42:11: error: ‘IFNAMSIZ’ undeclared here (not in a function) char dev[IFNAMSIZ]; /* Local device to use */ I'll fix these. -Mikko