From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752216AbbCKIn6 (ORCPT ); Wed, 11 Mar 2015 04:43:58 -0400 Received: from mga01.intel.com ([192.55.52.88]:60374 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751702AbbCKIn4 (ORCPT ); Wed, 11 Mar 2015 04:43:56 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,380,1422950400"; d="scan'208";a="465610935" Date: Wed, 11 Mar 2015 10:43:53 +0200 From: Mika Westerberg To: "Rafael J. Wysocki" Cc: Linus Walleij , Alexandre Courbot , linux-gpio@vger.kernel.org, Linux Kernel Mailing List , ACPI Devel Maling List Subject: Re: [PATCH 2/2] gpio / ACPI: Use local variable instead of ACPI_HANDLE() Message-ID: <20150311084353.GE1563@lahna.fi.intel.com> References: <4032246.STUT1iRmIk@vostro.rjw.lan> <15697166.UNaCUJRTg5@vostro.rjw.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <15697166.UNaCUJRTg5@vostro.rjw.lan> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 10, 2015 at 11:10:01PM +0100, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > In acpi_gpiochip_request_interrupts() the handle local > variable already contains the value that we want to pass > to acpi_walk_resources(), so it is better to use that > variable instead of evaluating ACPI_HANDLE() once more > for the same device. > > Signed-off-by: Rafael J. Wysocki Acked-by: Mika Westerberg