From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752113AbbCKKYN (ORCPT <rfc822;w@1wt.eu>);
	Wed, 11 Mar 2015 06:24:13 -0400
Received: from mail.kapsi.fi ([217.30.184.167]:40351 "EHLO mail.kapsi.fi"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751247AbbCKKYM (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 11 Mar 2015 06:24:12 -0400
Date: Wed, 11 Mar 2015 12:24:08 +0200
From: Mikko Rapeli <mikko.rapeli@iki.fi>
To: Michal Marek <mmarek@suse.cz>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@linux-foundation.org>,
        Javier Barrio <javier.barrio.mart@gmail.com>
Subject: Re: [PATCH 03/45] headers_install.sh: enhance error handling
Message-ID: <20150311102408.GH12550@lakka.kapsi.fi>
References: <1424127948-22484-1-git-send-email-mikko.rapeli@iki.fi>
 <1424127948-22484-4-git-send-email-mikko.rapeli@iki.fi>
 <54E33F7F.8020201@suse.cz>
 <20150310224448.GW12550@lakka.kapsi.fi>
 <550015EB.2010601@suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <550015EB.2010601@suse.cz>
X-SA-Exim-Connect-IP: 2001:1bc8:1004::1
X-SA-Exim-Mail-From: mikko.rapeli@iki.fi
X-SA-Exim-Scanned: No (on mail.kapsi.fi); SAEximRunCond expanded to false
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Mar 11, 2015 at 11:16:11AM +0100, Michal Marek wrote:
> On 2015-03-10 23:44, Mikko Rapeli wrote:
> > On Tue, Feb 17, 2015 at 02:17:51PM +0100, Michal Marek wrote:
> >> On 2015-02-17 00:05, Mikko Rapeli wrote:
> >>> Exit with error if using undefined variables or if any sub command fails
> >>> with error return value. unidef needs special handling since but this can
> >>> be done without the trap. Enables exaniming intermediate files if some
> >>> commands failed.
> >>
> >> The intermediate files are removed by your patch as well, aren't they?
> >> Actually, I don't see any change in behavior after your patch.
> > 
> > Yes, if everything succeeded without errors, then intermediate files
> > are removed. But the files are left around if something fails
> 
> They are not:
> 
> +		"$SRCDIR/$i" > "$OUTDIR/$FILE.sed" || \
> +		( rm -f "$OUTDIR/$FILE.sed" ; exit 1 )
> 
> This removes "$OUTDIR/$FILE.sed" if the sed command files. Just like the
> trap command has been doing.

Heh, you're right. I might as well change this to leave the sed script
around if something failed.

-Mikko