From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751274AbbCKLpi (ORCPT ); Wed, 11 Mar 2015 07:45:38 -0400 Received: from mail-qg0-f46.google.com ([209.85.192.46]:46127 "EHLO mail-qg0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750769AbbCKLpg (ORCPT ); Wed, 11 Mar 2015 07:45:36 -0400 Date: Wed, 11 Mar 2015 07:45:31 -0400 From: Tejun Heo To: Wolfram Sang Cc: linux-kernel@vger.kernel.org, linux-sh@vger.kernel.org Subject: Re: [PATCH] kernfs: remove outdated and confusing comment Message-ID: <20150311114531.GB25944@htj.duckdns.org> References: <1426069565-7933-1-git-send-email-wsa@the-dreams.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1426069565-7933-1-git-send-email-wsa@the-dreams.de> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 11, 2015 at 11:26:02AM +0100, Wolfram Sang wrote: > From: Wolfram Sang > > Grabbing the parent is not happening anymore since 2010 (e72ceb8ccac5f7 > "sysfs: Remove sysfs_get/put_active_two"). Remove this confusing > comment. > > Signed-off-by: Wolfram Sang Acked-by: Tejun Heo > Found while trying to find out why my sysfs-bin file always returns POLLPRI > after opening, reading, polling. Any pointers while I am here? :) Hmm... poll isn't hooked up for bin files and the behavior isn't well defined either. The open file's event counter is never synchronized to the backing node's. Before the first kernfs_notify(), it won't trigger and after always. We'll prolly need to define that better. What's the use case that you're interested in? Thanks. -- tejun