From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752129AbbCKMd7 (ORCPT ); Wed, 11 Mar 2015 08:33:59 -0400 Received: from mail.skyhub.de ([78.46.96.112]:50112 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750895AbbCKMd5 (ORCPT ); Wed, 11 Mar 2015 08:33:57 -0400 Date: Wed, 11 Mar 2015 13:32:33 +0100 From: Borislav Petkov To: Andy Lutomirski Cc: Andi Kleen , "H. Peter Anvin" , X86 ML , Al Viro , Linus Torvalds , "linux-kernel@vger.kernel.org" , Ingo Molnar Subject: Re: [PATCH v2 2/2] x86_64,signal: Remove 'fs' and 'gs' from sigcontext Message-ID: <20150311123233.GE16419@pd.tnic> References: <341cbb62a79e91becc87ac7fab78bc22eb87976e.1425995824.git.luto@amacapital.net> <20150311092817.GB16419@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 11, 2015 at 05:22:48AM -0700, Andy Lutomirski wrote: > Wait... It looks like it really was saving them. Of course, this is Bah, of course. Blind me. > IOW, in 2.5.63 and earlier, we tried to save and restore TLS state > across signals, but we did it wrong and would corrupt it for any > program that used arch_prctl. At that time, programs could switch > userspace threads using signals and their TLS pointers would switch. > In 2.5.64 and later, we broke set_thread_area users, fixed arch_prctl That is probably non-issue as 2.5 was the devel branch anyway in the old days. I'm not sure what the statement on breaking ABI was though then... -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. --