From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752821AbbCLSQE (ORCPT ); Thu, 12 Mar 2015 14:16:04 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:38147 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751019AbbCLSP7 (ORCPT ); Thu, 12 Mar 2015 14:15:59 -0400 Date: Thu, 12 Mar 2015 14:15:56 -0400 (EDT) Message-Id: <20150312.141556.780781968181122546.davem@davemloft.net> To: udknight@gmail.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, j.vosburgh@gmail.com, vfalico@gmail.com, gospo@cumulusnetworks.com Subject: Re: [PATCH] net:Kconfig: drop no sense dependence entry for BONDING From: David Miller In-Reply-To: <20150312135933.GA3502@udknight> References: <20150312135933.GA3502@udknight> X-Mailer: Mew version 6.5 on Emacs 24.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Wang YanQing Date: Thu, 12 Mar 2015 21:59:33 +0800 > "IPV6 || IPV6=n" means no dependence! > > Signed-off-by: Wang YanQing It is only nonsense because you don't actually understand what the statement does. It makes sure that either IPV6 is enabled and _EQUALS_ what BONDING is set to ("y" _or_ "m"), or it is disabled. This pattern is used all over the place and is quite common actually. Better to first ask what a statement does, than to knee-jerk submit a patch to remove it. Because patch submissions use up people's resources and time, particularly mine.