From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752337AbbCLShy (ORCPT ); Thu, 12 Mar 2015 14:37:54 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:38415 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751484AbbCLShw (ORCPT ); Thu, 12 Mar 2015 14:37:52 -0400 Date: Thu, 12 Mar 2015 14:37:49 -0400 (EDT) Message-Id: <20150312.143749.1356539359045388378.davem@davemloft.net> To: mst@redhat.com Cc: jasowang@redhat.com, rusty@rustcorp.com.au, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net] virtio-net: correctly delete napi hash From: David Miller In-Reply-To: <20150312082351-mutt-send-email-mst@redhat.com> References: <1426139864-25023-1-git-send-email-jasowang@redhat.com> <20150312082351-mutt-send-email-mst@redhat.com> X-Mailer: Mew version 6.5 on Emacs 24.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: "Michael S. Tsirkin" Date: Thu, 12 Mar 2015 08:25:34 +0100 > On Thu, Mar 12, 2015 at 01:57:44PM +0800, Jason Wang wrote: >> We don't delete napi from hash list during module exit. This will >> cause the following panic when doing module load and unload: ... >> This patch fixes this by doing this in virtnet_free_queues(). And also >> don't delete napi in virtnet_freeze() since it will call >> virtnet_free_queues() which has already did this. >> >> Fixes 91815639d880 ("virtio-net: rx busy polling support") >> Cc: Rusty Russell >> Cc: Michael S. Tsirkin >> Signed-off-by: Jason Wang ... > Dave, can you pick this up pls? > Looks like a stable candidate too. Applied and queued up for -stable, thanks.