From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751849AbbCLEqP (ORCPT ); Thu, 12 Mar 2015 00:46:15 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:53463 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751351AbbCLEqN (ORCPT ); Thu, 12 Mar 2015 00:46:13 -0400 Date: Wed, 11 Mar 2015 23:45:32 -0500 From: Felipe Balbi To: Scott Wood CC: , , , Felipe Balbi Subject: Re: [PATCH 18/22] usb: gadget: serial: %pF is only for function pointers Message-ID: <20150312044532.GB29718@saruman.tx.rr.com> Reply-To: References: <1426130037-17956-1-git-send-email-scottwood@freescale.com> <1426130037-17956-18-git-send-email-scottwood@freescale.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="zx4FCpZtqtKETZ7O" Content-Disposition: inline In-Reply-To: <1426130037-17956-18-git-send-email-scottwood@freescale.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --zx4FCpZtqtKETZ7O Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Mar 11, 2015 at 10:13:53PM -0500, Scott Wood wrote: > Use %pS for actual addresses, otherwise you'll get bad output > on arches like ppc64 where %pF expects a function descriptor. >=20 > Signed-off-by: Scott Wood > Cc: linux-usb@vger.kernel.org > Cc: Felipe Balbi > --- > drivers/usb/gadget/function/u_serial.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/drivers/usb/gadget/function/u_serial.c b/drivers/usb/gadget/= function/u_serial.c > index 491082a..89179ab 100644 > --- a/drivers/usb/gadget/function/u_serial.c > +++ b/drivers/usb/gadget/function/u_serial.c > @@ -912,7 +912,7 @@ static int gs_put_char(struct tty_struct *tty, unsign= ed char ch) > unsigned long flags; > int status; > =20 > - pr_vdebug("gs_put_char: (%d,%p) char=3D0x%x, called from %pf\n", > + pr_vdebug("gs_put_char: (%d,%p) char=3D0x%x, called from %ps\n", ^ S ?? --=20 balbi --zx4FCpZtqtKETZ7O Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVARnsAAoJEIaOsuA1yqRE4sYP/2A01EFnv5vLk4RCo0oLpwaB Dp7Ix/zm0WfOebxevSXi6WuZyNejNcNrABoHMbC2Si34bXC9GrrO46h11QxR7Zve lv1YYDOtr3BDqQ9LMpmWATnCWFtIMTSNoU10RSKfe/LEyOguZ/RtWGvL09T3qJW2 I4tlMptaelIgl0YntHdWIGEoRoEz8UY3G7cxRqoHqsZm35xfiI6sRbiJs/an31hl 9kySXV8y70nqYio3SMHo+WPP1JvVSPSjZycXn7zDpFIZ90QlCRcHvir13AkPIb7/ EWs9DVtbPnlXh/Qlt2Obh5YfNvn+mvK3nFf9QcPc58HvQPwXYcbi1EbD8ala9pUF yujIK1VVZyA6JjgmJLx+ENbTIL44Iqa9bHdLgAafbEqNQ+tJ9kIb4IyXVA0KScst N7KjHs8vd1JfoHmUclJDtIhjzBcXH8ofPM9xu3D3rhKkufOeQVbpxsVOyQZdIrg2 AAlr6mcZwXOGCzLEocq6lR3w1Z5abEMuCoioLhEjODADOkUgTUH+hsrtq0Qwti0h 50hH0dsir4HO30DVfyS3mzifxgzFx2Pcp9yICsuKQWKxoatiA3Dzw02ut9/IK2LO UtxtMClfsmh6jJ0VB2vEg+FOLBJRhGYgzbG48y5RwqhJZdTTyK8jO+q1in1K9Apr DJp+XSyh2N5p76Xvd31Y =ojLh -----END PGP SIGNATURE----- --zx4FCpZtqtKETZ7O--