From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753933AbbCLKA0 (ORCPT ); Thu, 12 Mar 2015 06:00:26 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:33340 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752528AbbCLKAX (ORCPT ); Thu, 12 Mar 2015 06:00:23 -0400 Date: Thu, 12 Mar 2015 11:00:18 +0100 From: Greg Kroah-Hartman To: Vivien Didelot Cc: Guenter Roeck , linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com Subject: Re: [PATCH v2 1/3] sysfs: Use only return value from is_visible for the file mode Message-ID: <20150312100018.GB3682@kroah.com> References: <1426098131-20106-1-git-send-email-vivien.didelot@savoirfairelinux.com> <1426098131-20106-2-git-send-email-vivien.didelot@savoirfairelinux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1426098131-20106-2-git-send-email-vivien.didelot@savoirfairelinux.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 11, 2015 at 02:22:09PM -0400, Vivien Didelot wrote: > From: Guenter Roeck > > Up to now, is_visible can only be used to either remove visibility > of a file entirely or to add permissions, but not to reduce permissions. > This makes it impossible, for example, to use DEVICE_ATTR_RW to define > file attributes and reduce permissions to read-only. > > This behavior is undesirable and unnecessarily complicates code which > needs to reduce permissions; instead of just returning the desired > permissions, it has to ensure that the permissions in the attribute > variable declaration only reflect the minimal permissions ever needed. > > Change semantics of is_visible to only use the permissions returned > from it instead of oring the returned value with the hard-coded > permissions. > > Cc: Vivien Didelot > Signed-off-by: Guenter Roeck > --- > fs/sysfs/group.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) Why have you not signed off on this patch if you sent it to me? Don't you agree with it? thanks, greg k-h