From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753501AbbCLKpq (ORCPT ); Thu, 12 Mar 2015 06:45:46 -0400 Received: from mo4-p00-ob.smtp.rzone.de ([81.169.146.162]:63743 "EHLO mo4-p00-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751121AbbCLKpp (ORCPT ); Thu, 12 Mar 2015 06:45:45 -0400 X-RZG-AUTH: :P2EQZWCpfu+qG7CngxMFH1J+yackYocTD1iAi8x+OWi/zfN1cLnBYfssV4pSFZalwAeMSYGGVMSyQaZuzod+milLZOzKSQ== X-RZG-CLASS-ID: mo00 Date: Thu, 12 Mar 2015 11:45:43 +0100 From: Olaf Hering To: "K. Y. Srinivasan" Cc: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, devel@linuxdriverproject.org, apw@canonical.com, vkuznets@redhat.com Subject: Re: [PATCH 2/6] Drivers: hv: hv_balloon: keep locks balanced on add_memory() failure Message-ID: <20150312104543.GB11353@aepfle.de> References: <1426125345-12530-1-git-send-email-kys@microsoft.com> <1426125419-12571-1-git-send-email-kys@microsoft.com> <1426125419-12571-2-git-send-email-kys@microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1426125419-12571-2-git-send-email-kys@microsoft.com> User-Agent: Mutt/1.5.22.rev6346 (2013-10-29) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 11, K. Y. Srinivasan wrote: > +++ b/drivers/hv/hv_balloon.c > @@ -652,6 +652,7 @@ static void hv_mem_hot_add(unsigned long start, unsigned long size, > } > has->ha_end_pfn -= HA_CHUNK; > has->covered_end_pfn -= processed_pfn; > + mutex_lock(&dm_device.ha_region_mutex); > break; > } Should it call the wrapper instead of doing mutex_lock directly? Like 'acquire_region_mutex(false);'. Olaf