From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753821AbbCLLlW (ORCPT ); Thu, 12 Mar 2015 07:41:22 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:29028 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752813AbbCLLlT (ORCPT ); Thu, 12 Mar 2015 07:41:19 -0400 Date: Thu, 12 Mar 2015 14:41:01 +0300 From: Dan Carpenter To: Olaf Hering Cc: Vitaly Kuznetsov , apw@canonical.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, devel@linuxdriverproject.org Subject: Re: [PATCH 2/6] Drivers: hv: hv_balloon: keep locks balanced on add_memory() failure Message-ID: <20150312114101.GB10964@mwanda> References: <1426125345-12530-1-git-send-email-kys@microsoft.com> <1426125419-12571-1-git-send-email-kys@microsoft.com> <1426125419-12571-2-git-send-email-kys@microsoft.com> <20150312104543.GB11353@aepfle.de> <87zj7isd0d.fsf@vitty.brq.redhat.com> <20150312111428.GA17163@aepfle.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150312111428.GA17163@aepfle.de> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: aserv0022.oracle.com [141.146.126.234] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 12, 2015 at 12:14:28PM +0100, Olaf Hering wrote: > On Thu, Mar 12, Vitaly Kuznetsov wrote: > > > My "Drivers: hv: hv_balloon: eliminate the trylock path in > > acquire/release_region_mutex" (b05d8d9ef5ef21d1b18440430f950304836e1aaa > > in char-misc-next) removed these wrappers. > > I see now. There are many changes in char-misc-next. The description > gives the impression that mainline is broken. Not sure if thats true, > perhaps its just char-misc-next which is affected. Mainline is broken. We only found these when we removed the wrapper and then static checkers were able to catch the bug. regards, dan carpenter