From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751531AbbCLTYc (ORCPT <rfc822;w@1wt.eu>);
	Thu, 12 Mar 2015 15:24:32 -0400
Received: from mail.linuxfoundation.org ([140.211.169.12]:43169 "EHLO
	mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755076AbbCLTXd (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 12 Mar 2015 15:23:33 -0400
Date: Thu, 12 Mar 2015 12:23:31 -0700
From: Andrew Morton <akpm@linux-foundation.org>
To: Andrew Vagin <avagin@parallels.com>
Cc: Andrey Vagin <avagin@openvz.org>, <linux-kernel@vger.kernel.org>,
        <linux-fsdevel@vger.kernel.org>, <linux-doc@vger.kernel.org>,
        Jonathan Corbet <corbet@lwn.net>,
        Alexander Viro <viro@zeniv.linux.org.uk>,
        Jeff Layton <jlayton@poochiereds.net>,
        "J. Bruce Fields" <bfields@fieldses.org>,
        "Cyrill Gorcunov" <gorcunov@openvz.org>,
        Pavel Emelyanov <xemul@parallels.com>, "Joe Perches" <joe@perches.com>
Subject: Re: [PATCH] proc: show locks in /proc/pid/fdinfo/X
Message-Id: <20150312122331.d8c27baf40d56e764f223193@linux-foundation.org>
In-Reply-To: <20150312155441.GA19139@paralelels.com>
References: <1425569838-20416-1-git-send-email-avagin@openvz.org>
	<20150311150853.492fee52def529e86506976b@linux-foundation.org>
	<20150312155441.GA19139@paralelels.com>
X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, 12 Mar 2015 18:54:42 +0300 Andrew Vagin <avagin@parallels.com> wrote:

> v2: use seq_has_overflowed() properly

--- a/fs/proc/fd.c~proc-show-locks-in-proc-pid-fdinfo-x-v2
+++ a/fs/proc/fd.c
@@ -57,17 +57,15 @@ static int seq_show(struct seq_file *m,
 		   real_mount(file->f_path.mnt)->mnt_id);
 
 	show_fd_locks(m, file, files);
-	ret = seq_has_overflowed(m);
-	if (ret)
+	if (seq_has_overflowed(m))
 		goto out;
 
 	if (file->f_op->show_fdinfo)
 		file->f_op->show_fdinfo(m, file);
-	ret = seq_has_overflowed(m);
 
 out:
 	fput(file);
-	return ret;
+	return 0;
 }
 
 static int seq_fdinfo_open(struct inode *inode, struct file *file)


So it returns "success" when the output has overflowed?  Why this,
rather than returning an error?