From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755041AbbCLOvb (ORCPT ); Thu, 12 Mar 2015 10:51:31 -0400 Received: from mail.skyhub.de ([78.46.96.112]:39861 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755028AbbCLOv1 (ORCPT ); Thu, 12 Mar 2015 10:51:27 -0400 Date: Thu, 12 Mar 2015 15:50:01 +0100 From: Borislav Petkov To: Daniel J Blueman Cc: Ingo Molnar , Thomas Gleixner , "H. Peter Anvin" , x86@kernel.org, linux-kernel@vger.kernel.org, Steffen Persvold Subject: Re: [PATCH v4] x86: Fix sibling map with NumaChip Message-ID: <20150312145001.GB25505@pd.tnic> References: <1426135950-10110-1-git-send-email-daniel@numascale.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1426135950-10110-1-git-send-email-daniel@numascale.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 12, 2015 at 12:52:30PM +0800, Daniel J Blueman wrote: > On NumaChip systems, the physical processor ID assignment wasn't accounting > for the number of nodes in AMD multi-module processors, giving an incorrect > sibling map: > > $ cd /sys/devices/system/cpu/cpu29/topology > $ grep . * > core_id:5 > core_siblings:00000000,ff000000 > core_siblings_list:24-31 > physical_package_id:3 > thread_siblings:00000000,30000000 > thread_siblings_list:28-29 > > After fixing: > > core_id:5 > core_siblings:00000000,ffff0000 > core_siblings_list:16-31 > physical_package_id:1 > thread_siblings:00000000,30000000 > thread_siblings_list:28-29 > > v2: Fix to check for MSR availability before use, as per Boris's feedback > v3: Test against boot cpu to correct behaviour on larger systems with global IO > v4: Use static_cpu_has_safe(), as Boris suggests > > Candidate for stable. > > Signed-off-by: Daniel J Blueman > --- > arch/x86/kernel/apic/apic_numachip.c | 22 ++++++++++++++++------ > 1 file changed, 16 insertions(+), 6 deletions(-) Queued for urgent/stable. Thanks. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. --