From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932563AbbCLO5g (ORCPT <rfc822;w@1wt.eu>);
	Thu, 12 Mar 2015 10:57:36 -0400
Received: from pandora.arm.linux.org.uk ([78.32.30.218]:40592 "EHLO
	pandora.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932391AbbCLO5b (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 12 Mar 2015 10:57:31 -0400
Date: Thu, 12 Mar 2015 14:57:13 +0000
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Fabrice GASNIER <fabrice.gasnier@st.com>
Cc: Tony Lindgren <tony@atomide.com>,
        Marek Szyprowski <m.szyprowski@samsung.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
        Tomasz Figa <t.figa@samsung.com>, Arnd Bergmann <arnd@arndb.de>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        tomasz.figa@gmail.com
Subject: Re: [PATCH v2] ARM: l2c: Fix prefetch settings dt parsing
Message-ID: <20150312145712.GT8656@n2100.arm.linux.org.uk>
References: <1425977941-31278-1-git-send-email-fabrice.gasnier@st.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1425977941-31278-1-git-send-email-fabrice.gasnier@st.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Mar 10, 2015 at 09:59:01AM +0100, Fabrice GASNIER wrote:
> Allow prefetch settings overriding by device tree, in case
> l2x0_cache_size_of_parse() returns value, prefetch tuning
> properties are silently ignored. E.g. arm,double-linefill* and
> arm,prefetch*.
> This happens for example, when "cache-size" or "cache-sets"
> properties haven't been filled in l2c dt node.
> 
> Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
> Reviewed-by: Tomasz Figa <tomasz.figa@gmail.com>

Patch is okay, but I think the commit message needs to be better :)

"Allow device tree to override the L2C prefetch settings, even when
l2x0_cache_size_of_parse() fails to parse the cache geometry due to (eg)
missing "cache-size" or "cache-sets" properties."

I think with something along those lines, the patch can be put in my
patch system for when I next get around to applying some kernel patches
instead of reading email. :)

Thanks.

-- 
FTTC broadband for 0.8mile line: currently at 10.5Mbps down 400kbps up
according to speedtest.net.