From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754700AbbCLPjQ (ORCPT ); Thu, 12 Mar 2015 11:39:16 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:50913 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754613AbbCLPjM (ORCPT ); Thu, 12 Mar 2015 11:39:12 -0400 Date: Thu, 12 Mar 2015 10:38:29 -0500 From: Felipe Balbi To: Scott Wood CC: , , , Subject: Re: [PATCH 18/22] usb: gadget: serial: %pF is only for function pointers Message-ID: <20150312153829.GB9261@saruman.tx.rr.com> Reply-To: References: <1426130037-17956-1-git-send-email-scottwood@freescale.com> <1426130037-17956-18-git-send-email-scottwood@freescale.com> <20150312044532.GB29718@saruman.tx.rr.com> <1426138027.30327.109.camel@freescale.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="s/l3CgOIzMHHjg/5" Content-Disposition: inline In-Reply-To: <1426138027.30327.109.camel@freescale.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --s/l3CgOIzMHHjg/5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Mar 12, 2015 at 12:27:07AM -0500, Scott Wood wrote: > On Wed, 2015-03-11 at 23:45 -0500, Felipe Balbi wrote: > > On Wed, Mar 11, 2015 at 10:13:53PM -0500, Scott Wood wrote: > > > Use %pS for actual addresses, otherwise you'll get bad output > > > on arches like ppc64 where %pF expects a function descriptor. > > >=20 > > > Signed-off-by: Scott Wood > > > Cc: linux-usb@vger.kernel.org > > > Cc: Felipe Balbi > > > --- > > > drivers/usb/gadget/function/u_serial.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > >=20 > > > diff --git a/drivers/usb/gadget/function/u_serial.c b/drivers/usb/gad= get/function/u_serial.c > > > index 491082a..89179ab 100644 > > > --- a/drivers/usb/gadget/function/u_serial.c > > > +++ b/drivers/usb/gadget/function/u_serial.c > > > @@ -912,7 +912,7 @@ static int gs_put_char(struct tty_struct *tty, un= signed char ch) > > > unsigned long flags; > > > int status; > > > =20 > > > - pr_vdebug("gs_put_char: (%d,%p) char=3D0x%x, called from %pf\n", > > > + pr_vdebug("gs_put_char: (%d,%p) char=3D0x%x, called from %ps\n", > > ^ > > S ?? >=20 > %ps is the non-function-pointer version of %pf. %pS is the > non-function-pointer version of %pF. I didn't change the capitalization > of any of these -- if that's warranted in some places, it's outside the > scope of this treewide patchset. then let's fix your commit log where you mention %pS but use %ps ;-) --=20 balbi --s/l3CgOIzMHHjg/5 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVAbL1AAoJEIaOsuA1yqRElLwP/jwZHzZpQmWMATs702w+xLgH Ktss2Mbmn6IOVR16/yzy3fj2cVfQN1sFg/1kxPXEvuMPEhDdpvtmDSdG/yHRIeEj jYWvvVfSu5A35Oq5eFhwI855sRJnJx4/Inlap7jni/Q+h0rugIQfQvD2TKn1aUC/ uQTNjh1pJ9AI81l+3VSDYvddo9GonpZ7if/RDQeUmSd2Vel7ar2qMNdrcEMcyxCc iGBbi/lky+54+XqEffOzqKqfFwcD1uZsrzO0CKNinzU+w1gycrsa0LQ+d5HI+aZd e8LVO+1+8qAKN6itTZ0wJO0F+GD9tZ4nzndr2LsDAFHYPXqcu5ygKu8hfMUHUq0Z wfiVwMOd8CA4MtarVtbvpe7G++tNTgJU0FdPBRUP7tdw7aeAgST0kK7HRi1bQyDV afsZtUdh2DEGyPCydIWXuyJduQiFIBX1a8PD/ORLgwxVHKiUFyFyZQJtvwMVLnf2 wT3QkVV1BDxJ1GIX39mvBvFgEabq1URfUL4RAOJofpnl7zrkc3VUZRjmCjc1fZ3Y xX+KtPft3+XgB3pmcCzdeRl3XEi86cZEh8kHXarhEqJVijiOZ4wiX2FrfbttjAZL KchktBQ+pi/9TTXbZ8qtEbRB28Hb8pP4WT04j871uiMMVOKk0WNJi7vfgs8FxzmZ kFShbOl52Mol6wjX/q75 =T3zV -----END PGP SIGNATURE----- --s/l3CgOIzMHHjg/5--