From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753123AbbCLXQk (ORCPT ); Thu, 12 Mar 2015 19:16:40 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:45691 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751509AbbCLXQh (ORCPT ); Thu, 12 Mar 2015 19:16:37 -0400 Date: Thu, 12 Mar 2015 16:16:36 -0700 From: Andrew Morton To: Nicholas Krause Cc: oleg@redhat.com, mhocko@suse.cz, mingo@kernel.org, peterz@infradead.org, ionut.m.alexa@gmail.com, riel@redhat.com, peter@hurleysoftware.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] kernel:Change the function definiton of do_exit to comply with its function prototypes in kernel.h Message-Id: <20150312161636.1e450cca1f4cad34555b751c@linux-foundation.org> In-Reply-To: <1426048610-6065-1-git-send-email-xerofoify@gmail.com> References: <1426048610-6065-1-git-send-email-xerofoify@gmail.com> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 11 Mar 2015 00:36:50 -0400 Nicholas Krause wrote: > This fixes the function definiton of do_exit to comply with its > function prototype as defined in kernel.h as found when running > sparse on the latest updated version of the mainline kernel. > > ... > > -void do_exit(long code) > +void do_exit(long error_code) We still have include/linux/module.h:#define module_put_and_exit(code) do_exit(code) Probably changing the header files is the way to go - error_code is a bit of a mouthful. Actually, using "exit_code" everywhere would be best - that's what the thing does, and it gets copied into task_struct.exit_code. And change complete_and_exit(code). do_group_exit() already uses exit_code. sys_exit_group() uses "error_code". It's rather a little mess we've made in there!