From: Guenter Roeck <linux@roeck-us.net>
To: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com
Subject: Re: [PATCH v3 2/3] sysfs: Only accept read/write permissions for file attributes
Date: Thu, 12 Mar 2015 09:37:36 -0700 [thread overview]
Message-ID: <20150312163736.GE15121@roeck-us.net> (raw)
In-Reply-To: <1426168708-10836-3-git-send-email-vivien.didelot@savoirfairelinux.com>
On Thu, Mar 12, 2015 at 09:58:27AM -0400, Vivien Didelot wrote:
> For sysfs file attributes, only read and write permissions make sense.
> Mask provided attribute permissions accordingly and send a warning
> to the console if invalid permission bits are set.
>
> This patch is originally from Guenter [1] and includes the fixup
> explained in the thread, that is printing permissions in octal format
> and limiting the scope of attributes to SYSFS_PREALLOC | 0664.
>
> [1] https://lkml.org/lkml/2015/1/19/599
>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
next prev parent reply other threads:[~2015-03-12 16:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-12 13:58 [PATCH v3 0/3] sysfs: Refine is_visible API Vivien Didelot
2015-03-12 13:58 ` [PATCH v3 1/3] sysfs: Use only return value from is_visible for the file mode Vivien Didelot
2015-03-12 13:58 ` [PATCH v3 2/3] sysfs: Only accept read/write permissions for file attributes Vivien Didelot
2015-03-12 16:37 ` Guenter Roeck [this message]
2015-03-12 13:58 ` [PATCH v3 3/3] sysfs: Document struct attribute_group Vivien Didelot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150312163736.GE15121@roeck-us.net \
--to=linux@roeck-us.net \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@savoirfairelinux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®