From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756089AbbCLVsA (ORCPT ); Thu, 12 Mar 2015 17:48:00 -0400 Received: from mail-ie0-f177.google.com ([209.85.223.177]:35543 "EHLO mail-ie0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754562AbbCLVr5 (ORCPT ); Thu, 12 Mar 2015 17:47:57 -0400 Date: Thu, 12 Mar 2015 14:47:52 -0700 From: Dmitry Torokhov To: Olivier Sobrie Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] input: misc: pwm-beeper: remove useless call to pwm_config() Message-ID: <20150312214752.GB4720@dtor-ws> References: <1426165770-11130-1-git-send-email-olivier@sobrie.be> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1426165770-11130-1-git-send-email-olivier@sobrie.be> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 12, 2015 at 02:09:30PM +0100, Olivier Sobrie wrote: > Calling pwm_config() with a period equal to zero always results in > error (-EINVAL) and pwm chip config method is never called. > > Signed-off-by: Olivier Sobrie Applied, thank you. > --- > drivers/input/misc/pwm-beeper.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/input/misc/pwm-beeper.c b/drivers/input/misc/pwm-beeper.c > index a28ee70..2a23643 100644 > --- a/drivers/input/misc/pwm-beeper.c > +++ b/drivers/input/misc/pwm-beeper.c > @@ -50,7 +50,6 @@ static int pwm_beeper_event(struct input_dev *input, > } > > if (value == 0) { > - pwm_config(beeper->pwm, 0, 0); > pwm_disable(beeper->pwm); > } else { > period = HZ_TO_NANOSECONDS(value); > -- > 1.9.1 > -- Dmitry