From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753094AbbCMJQN (ORCPT ); Fri, 13 Mar 2015 05:16:13 -0400 Received: from mail-wi0-f172.google.com ([209.85.212.172]:38236 "EHLO mail-wi0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751736AbbCMJQJ (ORCPT ); Fri, 13 Mar 2015 05:16:09 -0400 Date: Fri, 13 Mar 2015 10:17:50 +0100 From: Daniel Vetter To: Scott Wood Cc: trivial@kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH 15/22] drm: %pF is only for function pointers Message-ID: <20150313091750.GB3800@phenom.ffwll.local> Mail-Followup-To: Scott Wood , trivial@kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org References: <1426130037-17956-1-git-send-email-scottwood@freescale.com> <1426130037-17956-15-git-send-email-scottwood@freescale.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1426130037-17956-15-git-send-email-scottwood@freescale.com> X-Operating-System: Linux phenom 4.0.0-rc3+ User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 11, 2015 at 10:13:50PM -0500, Scott Wood wrote: > Use %pS for actual addresses, otherwise you'll get bad output > on arches like ppc64 where %pF expects a function descriptor. > > Signed-off-by: Scott Wood > Cc: dri-devel@lists.freedesktop.org Applied to drm-misc, thanks. -Daniel > --- > drivers/gpu/drm/drm_drv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c > index d512134..48f7359 100644 > --- a/drivers/gpu/drm/drm_drv.c > +++ b/drivers/gpu/drm/drm_drv.c > @@ -70,7 +70,7 @@ void drm_err(const char *format, ...) > vaf.fmt = format; > vaf.va = &args; > > - printk(KERN_ERR "[" DRM_NAME ":%pf] *ERROR* %pV", > + printk(KERN_ERR "[" DRM_NAME ":%ps] *ERROR* %pV", > __builtin_return_address(0), &vaf); > > va_end(args); > -- > 2.1.0 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch