From: David Sterba <dsterba@suse.cz>
To: "Yeon, JeHyeon (Tom)" <Tom.Yeon@windriver.com>
Cc: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: LZ4 : fix the data abort issue.
Date: Fri, 13 Mar 2015 12:22:46 +0100 [thread overview]
Message-ID: <20150313112246.GH20767@twin.jikos.cz> (raw)
In-Reply-To: <D2D54504A8A67848B028EBEA66F47B9AB2A2305A@ALA-MBA.corp.ad.wrs.com>
On Thu, Mar 12, 2015 at 08:28:55AM +0000, Yeon, JeHyeon (Tom) wrote:
> If the part of the compression data are corrupted, or the compression
> data is totally fake, the memory access over the limit is possible.
>
> This is the log from my system usning lz4 decompression.
> [6502]data abort, halting
> [6503]r0 0x00000000 r1 0x00000000 r2 0xdcea0ffc r3 0xdcea0ffc
> [6509]r4 0xb9ab0bfd r5 0xdcea0ffc r6 0xdcea0ff8 r7 0xdce80000
> [6515]r8 0x00000000 r9 0x00000000 r10 0x00000000 r11 0xb9a98000
> [6522]r12 0xdcea1000 usp 0x00000000 ulr 0x00000000 pc 0x820149bc
> [6528]spsr 0x400001f3
> and the memory addresses of some variables at the moment are
> ref:0xdcea0ffc, op:0xdcea0ffc, oend:0xdcea1000
>
> As you can see, COPYLENGH is 8bytes, so @ref and @op can access the momory
> over @oend.
>
> Signed-off-by: tom.yeon <tom.yeon@windriver.com>
Reviewed-by: David Sterba <dsterba@suse.cz>
Matches implementation in lz4 upstream.
Btw, why is it a reply and not a standalone patch? I don't seem to find
any prior message in relevant mailinglists.
next prev parent reply other threads:[~2015-03-13 11:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <D2D54504A8A67848B028EBEA66F47B9AB2A22E9E@ALA-MBA.corp.ad.wrs.com>
[not found] ` <20150312074918.GC31132@kroah.com>
2015-03-12 8:28 ` Yeon, JeHyeon (Tom)
2015-03-13 11:22 ` David Sterba [this message]
2015-03-13 13:23 ` gregkh
2015-03-16 1:03 ` 회신: " Yeon, JeHyeon (Tom)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150313112246.GH20767@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=Tom.Yeon@windriver.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®