From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030354AbbCMS0I (ORCPT ); Fri, 13 Mar 2015 14:26:08 -0400 Received: from smtprelay0115.hostedemail.com ([216.40.44.115]:55190 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751913AbbCMS0G (ORCPT ); Fri, 13 Mar 2015 14:26:06 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::::::::::::::,RULES_HIT:41:69:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1431:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2693:3138:3139:3140:3141:3142:3167:3352:3622:3865:3866:3868:3870:3872:3874:5007:6261:6742:7514:7875:10004:10400:10450:10455:10848:10967:11026:11232:11473:11658:11914:12043:12517:12519:12740:13069:13311:13357:13846:14096:14097:19904:19999:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: twist25_17ba3a7ac4a1c X-Filterd-Recvd-Size: 2485 Date: Fri, 13 Mar 2015 14:26:02 -0400 From: Steven Rostedt To: Denys Vlasenko Cc: Andy Lutomirski , Linus Torvalds , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Oleg Nesterov , Frederic Weisbecker , Alexei Starovoitov , Will Drewry , Kees Cook , x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] x86: simplify task_pt_regs() macro definition Message-ID: <20150313142602.15e6f4be@gandalf.local.home> In-Reply-To: <1426255743-5394-1-git-send-email-dvlasenk@redhat.com> References: <1426255743-5394-1-git-send-email-dvlasenk@redhat.com> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 13 Mar 2015 15:09:03 +0100 Denys Vlasenko wrote: > Before this change, task_pt_regs() was using KSTK_TOP(), > and it was the only use of that macro. In turn, KSTK_TOP used > THREAD_SIZE_LONGS, and it was the only use of that macro too. > > Fold these macros into task_pt_regs(). Tweak comment > about "- 8" - we now use a symbolic constant, not literal 8. I wonder if we should mention "8" at all? As for the patch, from what I can tell, it keeps the same logic. Reviewed-by: Steven Rostedt -- Steve > Signed-off-by: Denys Vlasenko > CC: Linus Torvalds > CC: Steven Rostedt > CC: Ingo Molnar > CC: Borislav Petkov > CC: "H. Peter Anvin" > CC: Andy Lutomirski > CC: Oleg Nesterov > CC: Frederic Weisbecker > CC: Alexei Starovoitov > CC: Will Drewry > CC: Kees Cook > CC: x86@kernel.org > CC: linux-kernel@vger.kernel.org > --- > arch/x86/include/asm/processor.h | 20 ++++++-------------- > 1 file changed, 6 insertions(+), 14 deletions(-)