From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757432AbbCMPeY (ORCPT ); Fri, 13 Mar 2015 11:34:24 -0400 Received: from mga11.intel.com ([192.55.52.93]:26914 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751732AbbCMPeU (ORCPT ); Fri, 13 Mar 2015 11:34:20 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,395,1422950400"; d="scan'208";a="466875402" Date: Fri, 13 Mar 2015 17:34:16 +0200 From: Mika Westerberg To: "Rafael J. Wysocki" Cc: ACPI Devel Maling List , Linux Kernel Mailing List , Bjorn Helgaas Subject: Re: [PATCH] PNP / ACPI: Use ACPI_COMPANION_SET() during initialization Message-ID: <20150313153416.GS1563@lahna.fi.intel.com> References: <1562702.j1oaNJkYhk@vostro.rjw.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1562702.j1oaNJkYhk@vostro.rjw.lan> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 13, 2015 at 01:45:49AM +0100, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > > pnpacpi_add_device() calls acpi_bind_one() on an already registered > device, which is a mistake, but it can initialize the ACPI companion > field of the struct device to be registered using ACPI_COMPANION_SET() > instead, so make it do that. > > Signed-off-by: Rafael J. Wysocki Makes sense. Reviewed-by: Mika Westerberg