From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752135AbbCNGjN (ORCPT ); Sat, 14 Mar 2015 02:39:13 -0400 Received: from cantor2.suse.de ([195.135.220.15]:37868 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750787AbbCNGjK (ORCPT ); Sat, 14 Mar 2015 02:39:10 -0400 Date: Sat, 14 Mar 2015 07:39:06 +0100 From: Jan Kara To: Fabian Frederick Cc: linux-kernel@vger.kernel.org, Jan Kara Subject: Re: [PATCH 2/5 linux-next] udf: use sector_t for udf_bitmap_prealloc_blocks() return value Message-ID: <20150314063906.GB2888@quack.suse.cz> References: <1426020276-13609-1-git-send-email-fabf@skynet.be> <1426020276-13609-2-git-send-email-fabf@skynet.be> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1426020276-13609-2-git-send-email-fabf@skynet.be> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 10-03-15 21:44:32, Fabian Frederick wrote: > udf_bitmap_prealloc_blocks() can only return positive value and is only > used to assign sector_t allocated. The return value is number of allocated blocks. There's no good reason to change that to sector_t... The variable 'allocated' in udf_prealloc_blocks() could be int if anything. Honza > > Signed-off-by: Fabian Frederick > --- > fs/udf/balloc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/udf/balloc.c b/fs/udf/balloc.c > index 02948f0..30f4641 100644 > --- a/fs/udf/balloc.c > +++ b/fs/udf/balloc.c > @@ -170,7 +170,7 @@ error_return: > mutex_unlock(&sbi->s_alloc_mutex); > } > > -static int udf_bitmap_prealloc_blocks(struct super_block *sb, > +static sector_t udf_bitmap_prealloc_blocks(struct super_block *sb, > struct udf_bitmap *bitmap, > uint16_t partition, uint32_t first_block, > uint32_t block_count) > -- > 1.9.1 > -- Jan Kara SUSE Labs, CR