From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751761AbbCPHYj (ORCPT ); Mon, 16 Mar 2015 03:24:39 -0400 Received: from cantor2.suse.de ([195.135.220.15]:45643 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750736AbbCPHYi (ORCPT ); Mon, 16 Mar 2015 03:24:38 -0400 Date: Mon, 16 Mar 2015 08:24:33 +0100 From: Jan Kara To: Fabian Frederick Cc: linux-kernel@vger.kernel.org, Jan Kara Subject: Re: [PATCH 1/1 linux-next] udf: use int for allocated blocks instead of sector_t Message-ID: <20150316072433.GA4934@quack.suse.cz> References: <1426413263-3466-1-git-send-email-fabf@skynet.be> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1426413263-3466-1-git-send-email-fabf@skynet.be> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun 15-03-15 10:54:23, Fabian Frederick wrote: > Fix the following warnings: > > fs/udf/balloc.c:768:15: warning: conversion to 'sector_t' from 'int' > may change the sign of the result [-Wsign-conversion] > allocated = udf_bitmap_prealloc_blocks(sb, > ^ > fs/udf/balloc.c:773:15: warning: conversion to 'sector_t' from 'int' > may change the sign of the result [-Wsign-conversion] > allocated = udf_table_prealloc_blocks(sb, > ^ > fs/udf/balloc.c:778:15: warning: conversion to 'sector_t' from 'int' > may change the sign of the result [-Wsign-conversion] > allocated = udf_bitmap_prealloc_blocks(sb, > ^ > fs/udf/balloc.c:783:15: warning: conversion to 'sector_t' from 'int' > may change the sign of the result [-Wsign-conversion] > allocated = udf_table_prealloc_blocks(sb, > ^ > fs/udf/balloc.c:791:26: warning: conversion to 'loff_t' from 'sector_t' > may change the sign of the result [-Wsign-conversion] > inode_add_bytes(inode, allocated << sb->s_blocksize_bits); > ^ > fs/udf/balloc.c:792:2: warning: conversion to 'int' from 'sector_t' > may alter its value [-Wconversion] > return allocated; > > Suggested-by: Jan Kara > Signed-off-by: Fabian Frederick Thanks. Applied to my tree. Honza > --- > fs/udf/balloc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/udf/balloc.c b/fs/udf/balloc.c > index 1ba2baa..75d5f421 100644 > --- a/fs/udf/balloc.c > +++ b/fs/udf/balloc.c > @@ -762,7 +762,7 @@ inline int udf_prealloc_blocks(struct super_block *sb, > uint32_t block_count) > { > struct udf_part_map *map = &UDF_SB(sb)->s_partmaps[partition]; > - sector_t allocated; > + int allocated; > > if (map->s_partition_flags & UDF_PART_FLAG_UNALLOC_BITMAP) > allocated = udf_bitmap_prealloc_blocks(sb, > -- > 1.9.1 > -- Jan Kara SUSE Labs, CR