From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755468AbbCPQaW (ORCPT ); Mon, 16 Mar 2015 12:30:22 -0400 Received: from mail-qc0-f177.google.com ([209.85.216.177]:33797 "EHLO mail-qc0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754859AbbCPQaT (ORCPT ); Mon, 16 Mar 2015 12:30:19 -0400 Date: Mon, 16 Mar 2015 12:30:14 -0400 From: Tejun Heo To: NeilBrown Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Prakash Punnoor , Torsten Kaiser , linux RAID Subject: Re: [PATCH] kernfs: handle poll correctly on 'direct_read' files. Message-ID: <20150316163014.GA8353@htj.duckdns.org> References: <20150316104452.366bffc0@notabene.brown> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150316104452.366bffc0@notabene.brown> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 16, 2015 at 10:44:52AM +1100, NeilBrown wrote: > > > Kernfs supports two styles of read: direct_read and seqfile_read. > > The latter supports 'poll' correctly thanks to the update of > '->event' in kernfs_seq_show. > The former does not as '->event' is never updated on a read. > > So add an appropriate update in kernfs_file_direct_read(). > > This was noticed because some 'md' sysfs attributes were > recently changed to use direct reads. > > Reported-by: Prakash Punnoor > Reported-by: Torsten Kaiser > Fixes: 750f199ee8b578062341e6ddfe36c59ac8ff2dcb This fixes tag is kinda weird without further explanation. > Signed-off-by: NeilBrown Acked-by: Tejun Heo Thanks. -- tejun