From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757031AbbCPRSH (ORCPT ); Mon, 16 Mar 2015 13:18:07 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:47393 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750886AbbCPRSF (ORCPT ); Mon, 16 Mar 2015 13:18:05 -0400 Date: Mon, 16 Mar 2015 17:17:55 +0000 From: Mark Brown To: Charles Keepax Cc: lee.jones@linaro.org, sameo@linux.intel.com, lgirdwood@gmail.com, patches@opensource.wolfsonmicro.com, linux-kernel@vger.kernel.org Message-ID: <20150316171755.GV28806@sirena.org.uk> References: <1426525124-12317-1-git-send-email-ckeepax@opensource.wolfsonmicro.com> <1426525124-12317-5-git-send-email-ckeepax@opensource.wolfsonmicro.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="muZOxeWw7VP4OgIK" Content-Disposition: inline In-Reply-To: <1426525124-12317-5-git-send-email-ckeepax@opensource.wolfsonmicro.com> X-Cookie: Editing is a rewording activity. User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 5/5] mfd: wm5110: Set DCVDD voltage to 1.175V before entering sleep mode X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --muZOxeWw7VP4OgIK Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Mar 16, 2015 at 04:58:44PM +0000, Charles Keepax wrote: > + } else { > + switch (arizona->type) { > + case WM5110: > + case WM8280: > + ret = regulator_set_voltage(arizona->dcvdd, > + 1175000, 1175000); > + if (ret < 0) { Can we please have a comment about this being the internal LDO and us therefore knowing exactly what voltages it supports (or just that it's the on chip LDO)? Going for a single voltage with zero tolerance is usually bad practice since it causes needless interoperability issues (eg, here the chances that the hardware would mind if an external regulator were only able to deliver 1.174V rather than 1.175V are minimal). This is fine here but people might be looking for examples and get the wrong idea. --muZOxeWw7VP4OgIK Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVBxBDAAoJECTWi3JdVIfQo7AH/0T3YJHfmsgCfYvd/viVB26X s1YvVMKMhq+0IEHKP2Mud6hTz1nDTRcvDr7Up13WmHjx2gewe1ltT1GLmJSZIJ4I 9XL7N9O/fkKvWW0t7Y8vpBYomL6hgRUPB/Dfl7QDFpnJGwYOaq4Uaz5Pm117Cm5v JvlhJle6Q4MKY+sxOpM3HDfEwfyLdpOpHjqo6rh71ssqWk2Huzera+FdWtMeFUdO qXtSyU+UneCPHQbUOd0OSSj3VqQJrpG9N8iGrMtvTRBlWEBZT0xzZiSBiLQNU0ON jhYaNpsvq3cN11WFEJXRat3psPBgBTeQa7T3cP/wc2xhho7DfmjW6Q+XCQcEYcI= =zxMy -----END PGP SIGNATURE----- --muZOxeWw7VP4OgIK--