From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933474AbbCPUrZ (ORCPT ); Mon, 16 Mar 2015 16:47:25 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:47732 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932456AbbCPUrV (ORCPT ); Mon, 16 Mar 2015 16:47:21 -0400 Date: Mon, 16 Mar 2015 20:47:10 +0000 From: Mark Brown To: Charles Keepax Cc: lee.jones@linaro.org, sameo@linux.intel.com, lgirdwood@gmail.com, patches@opensource.wolfsonmicro.com, linux-kernel@vger.kernel.org Message-ID: <20150316204710.GX28806@sirena.org.uk> References: <1426525124-12317-1-git-send-email-ckeepax@opensource.wolfsonmicro.com> <1426525124-12317-3-git-send-email-ckeepax@opensource.wolfsonmicro.com> <20150316171232.GU28806@sirena.org.uk> <20150316184518.GB23705@opensource.wolfsonmicro.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="t/uK68FT6w3kkRAy" Content-Disposition: inline In-Reply-To: <20150316184518.GB23705@opensource.wolfsonmicro.com> X-Cookie: Editing is a rewording activity. User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 3/5] mfd: wm5110: Add delay before releasing reset line on cold boot X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --t/uK68FT6w3kkRAy Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Mar 16, 2015 at 06:45:18PM +0000, Charles Keepax wrote: > I think your suspend example is pretty tricky, we enable the > regulators for the core_supplies at boot, so I guess we have > requested that the system never removes those so if it does so > anyway perhaps that is a system problem? There isn't really No, there's no guarantee that the current state is maintained over system suspend - system suspend can turn anything off (at least from an API point of view). > That would leave the only possible solution being a hard reset > during every runtime resume but that makes me very nervous about > the AoD interrupts as state for those would be lost upon that > reset. No, you're guaranteed that the supply will stay on while the system is running so runtime PM is not an issue - it's system suspend that's an issue. > All in all, I really struggle to see what more the driver could > do here. As I suggested in my original reply handle system suspend. --t/uK68FT6w3kkRAy Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVB0FNAAoJECTWi3JdVIfQUvUH/2MoULnnFVdIOl+A9TlonCmg Q1KCtH3QXhm3XJj+YA/sQPl8R5fEGFU2/9jdTA11YJAReCJ/XnQhUhISgsqRQ1tL kJ7oh393RpSfzc4LApK+KMctNSDMVYWKBc4JdF4M/Ax2mQy1Mo3ofC9rgUBNYA/s ikfr3/5iOLVBq94b3djGAUsMX+zRnNVwzVEgWDOR99825ZFpsDJeEALYpgANQdsy 52SA1Cy7iTkG8IwEux4aMkIDLX7neqkqSbSdX8wA3Mm+XarenbGKUaX4ASkmCC+2 kBL6XjudsPxryWFsETSPL8N/tiXoLoqNHMbFDa7XhJSOQyxyYf2qXL4if8/H8ms= =PrNO -----END PGP SIGNATURE----- --t/uK68FT6w3kkRAy--