From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752207AbbCQDz7 (ORCPT ); Mon, 16 Mar 2015 23:55:59 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:54666 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751478AbbCQDz5 (ORCPT ); Mon, 16 Mar 2015 23:55:57 -0400 Date: Mon, 16 Mar 2015 22:54:52 -0500 From: Felipe Balbi To: nick CC: Peter Chen , "gregkh@linuxfoundation.org" , "balbi@ti.com" , "ergei.shtylyov@cogentembedded.com" , "varkab@cdac.in" , "yoshihiro.shimoda.uh@renesas.com" , "ulrich.hecht@gmail.com" , "takeshi.kihara.df@renesas.com" , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: Possible no longer required cast in the function,usbhs_parse_dt in common.c Message-ID: <20150317035452.GB29805@saruman.tx.rr.com> Reply-To: References: <55079FF2.6060201@gmail.com> <5507A4B3.1020704@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="XOIedfhf+7KOe/yw" Content-Disposition: inline In-Reply-To: <5507A4B3.1020704@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --XOIedfhf+7KOe/yw Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Mar 16, 2015 at 11:51:15PM -0400, nick wrote: >=20 >=20 > On 2015-03-16 11:37 PM, Peter Chen wrote: > > =20 > >> > >> Greetings All, > >> I have been getting the below build warnings: > >> drivers/usb/renesas_usbhs/common.c: In function =E2=80=98usbhs_parse_d= t=E2=80=99: > >> drivers/usb/renesas_usbhs/common.c:482:25: warning: cast from pointer = to > >> integer of different size [-Wpointer-to-int-cast] > >> dparam->type =3D of_id ? (u32)of_id->data : 0; > >> After looking into the function I am curious if the hardware is only 3= 2 bit as if > >> the supported hardware for this driver is then this cast is no longer = required > >> and I can send in a patch removing it. Furthermore, sorry for the simp= le > >> question but I don't have access to the device specs for supported ha= rdware > >> so I though it would be better to ask before I send in patch fixing th= is issue. > >> Thanks, > >> Nick > >=20 > > Patch is welcome, there will be comment if it is not suitable. > >=20 > > Peter > >=20 > I understand that,my question was does the hardware for this driver suppo= rt 64 bit. regardless, it shouldn't produce a build warning. --=20 balbi --XOIedfhf+7KOe/yw Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVB6WMAAoJEIaOsuA1yqREuDYP/jibfvGTyC6sGoLIdZkRsaIo MkrddYeeYIma+5abfH3T7QUSspVfWTS7Fg4dX/pvyQgw0v3LcqhdIhAv9HBoJONH o9bn21N/YcxsDV77j0d6gc/EiamY1YKtndsFPKIgSfKwgLwZLF9Hg7tUR4L/+qOd 2hKuHPYGIDcRU1R85Z3O79i/yjsCJzbCoghD35WY6T10/gCEDgNv3Y3v/zreActl iXaHgK/9HqMxDFKAwCvVdipZHG6aYE8Pfl9eEIkJAGCJQc7jyugd8A0fDe65DiHk ncJ/+joY0TXTKIEikyMuAKpGzfFJLj0PPa62xrAxIyd17yg7FSLeioVuGdq+AD4e 07pupYBGI4H1HQOkp96Vd4nnSeJx7pfRBlF6yh41vUHUEyT8PMsO5PXQnGOsEfL4 ayq/CslLMApsg2+Otu+FxfK0q4Oobdfs382NcSOEYdZp3L7GSdf7vtEipAM71Wp8 M6/h4AwGcx0xeKWx3E2KZVI5FFNK0MR1d2TPUXxGFjgawD4l13r7BcG4BcrNwsQl B6u066rSPLO7j+4e1oIyoaQDbD2ccK7zEN2EHbVubIWynmJkuCHLJSEvxeO5DTo/ W9TSpfl36oHhCtE11sBy8HZK5MJcx7Y1/VF8DOfGu0tpBShVyOUj+60FHav8kitS ARZdY4dks+j4mi3cyMWI =l1h9 -----END PGP SIGNATURE----- --XOIedfhf+7KOe/yw--