From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751954AbbCQEOu (ORCPT ); Tue, 17 Mar 2015 00:14:50 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:59988 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750734AbbCQEOr (ORCPT ); Tue, 17 Mar 2015 00:14:47 -0400 Date: Mon, 16 Mar 2015 23:13:37 -0500 From: Felipe Balbi To: nick CC: , Peter Chen , "gregkh@linuxfoundation.org" , "ergei.shtylyov@cogentembedded.com" , "varkab@cdac.in" , "yoshihiro.shimoda.uh@renesas.com" , "ulrich.hecht@gmail.com" , "takeshi.kihara.df@renesas.com" , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: Possible no longer required cast in the function,usbhs_parse_dt in common.c Message-ID: <20150317041337.GA31114@saruman.tx.rr.com> Reply-To: References: <55079FF2.6060201@gmail.com> <5507A4B3.1020704@gmail.com> <20150317035452.GB29805@saruman.tx.rr.com> <5507A5EA.8040509@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="KsGdsel6WgEHnImy" Content-Disposition: inline In-Reply-To: <5507A5EA.8040509@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --KsGdsel6WgEHnImy Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Mar 16, 2015 at 11:56:26PM -0400, nick wrote: >=20 >=20 > On 2015-03-16 11:54 PM, Felipe Balbi wrote: > > On Mon, Mar 16, 2015 at 11:51:15PM -0400, nick wrote: > >> > >> > >> On 2015-03-16 11:37 PM, Peter Chen wrote: > >>> =20 > >>>> > >>>> Greetings All, > >>>> I have been getting the below build warnings: > >>>> drivers/usb/renesas_usbhs/common.c: In function =E2=80=98usbhs_parse= _dt=E2=80=99: > >>>> drivers/usb/renesas_usbhs/common.c:482:25: warning: cast from pointe= r to > >>>> integer of different size [-Wpointer-to-int-cast] > >>>> dparam->type =3D of_id ? (u32)of_id->data : 0; > >>>> After looking into the function I am curious if the hardware is only= 32 bit as if > >>>> the supported hardware for this driver is then this cast is no longe= r required > >>>> and I can send in a patch removing it. Furthermore, sorry for the si= mple > >>>> question but I don't have access to the device specs for supported = hardware > >>>> so I though it would be better to ask before I send in patch fixing = this issue. > >>>> Thanks, > >>>> Nick > >>> > >>> Patch is welcome, there will be comment if it is not suitable. > >>> > >>> Peter > >>> > >> I understand that,my question was does the hardware for this driver su= pport 64 bit. > >=20 > > regardless, it shouldn't produce a build warning. > >=20 > It does for me. yes, and I'm saying that's wrong. Regardless of the platform supporting 64bit or not, if the driver is allowed to build in 64bit configurations, there should be no warnings; if there are, they should be fixed and patches are very welcome. --=20 balbi --KsGdsel6WgEHnImy Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVB6nxAAoJEIaOsuA1yqREYyEP/11iIgrpWmF8A/ZR8UhXyBnr OfIfTbEb0JdnqFMCRCxPIny0+888DDNIHgeJGxDhAfenqnCWMMoBz2uyZtLhvc8J J8Ckvhqth6u5FIHXM+WBpbGTzSU3gkXNtwMEpTrLtc3zo5gVJcscDMppCq89/IL6 eP8GMItzGBDzUwKl7NFvIaqDE4wdjA+xcYoFWjX8ZYluqjk6MYPWxUxOdRDUgJbD pNba5av28fPj5q35fx7e3pcvQcnSlcPNLb+lKUrGZtevrDzkcTYf2HJa0QvAovcq H1WCSD+N5ZLU4ZpqLP72/eK6Wp/p+z5IXnqxIEj5iNptPcABjJJ7D/cyVMCaEf8e TVFfaunINM0B1iEgEyhuBGEgOku1SUoyitJKNPTxXqzPqLPNzW8LLM0W+9ZY1L+x Wx7UDmUlyQZgw7iqRXS+OZjaovx84HOqOX9dbyncAsyQFXmsqulhZftg10csqPLX VAAqtd06tTXTsYJw3nEcfBx76orbdXq9MHizbYSDPMt58V73hk7amKytEZ4Oz5jT VaWYemOc8dZ02i8ICX1VdC6TXPnkPTxpWxYI7Slg2XbI59C6LUHI97oRmyAA8CDQ Ful01Vuoc9hQ7mTb747lcYfU1GQr9d/vH6YVt+Q0OoDOADIg5zUrOkbKFiFXFC70 3487pL98X5c/6Gj9x5/B =icnb -----END PGP SIGNATURE----- --KsGdsel6WgEHnImy--