From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752202AbbCQEPU (ORCPT ); Tue, 17 Mar 2015 00:15:20 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:60018 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750782AbbCQEPR (ORCPT ); Tue, 17 Mar 2015 00:15:17 -0400 Date: Mon, 16 Mar 2015 23:14:19 -0500 From: Felipe Balbi To: nick CC: , Peter Chen , "gregkh@linuxfoundation.org" , "ergei.shtylyov@cogentembedded.com" , "varkab@cdac.in" , "yoshihiro.shimoda.uh@renesas.com" , "ulrich.hecht@gmail.com" , "takeshi.kihara.df@renesas.com" , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: Possible no longer required cast in the function,usbhs_parse_dt in common.c Message-ID: <20150317041419.GB31114@saruman.tx.rr.com> Reply-To: References: <55079FF2.6060201@gmail.com> <5507A4B3.1020704@gmail.com> <20150317035452.GB29805@saruman.tx.rr.com> <5507A5EA.8040509@gmail.com> <5507A941.6010800@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="ftEhullJWpWg/VHq" Content-Disposition: inline In-Reply-To: <5507A941.6010800@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --ftEhullJWpWg/VHq Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Mar 17, 2015 at 12:10:41AM -0400, nick wrote: >=20 >=20 > On 2015-03-16 11:56 PM, nick wrote: > >=20 > >=20 > > On 2015-03-16 11:54 PM, Felipe Balbi wrote: > >> On Mon, Mar 16, 2015 at 11:51:15PM -0400, nick wrote: > >>> > >>> > >>> On 2015-03-16 11:37 PM, Peter Chen wrote: > >>>> =20 > >>>>> > >>>>> Greetings All, > >>>>> I have been getting the below build warnings: > >>>>> drivers/usb/renesas_usbhs/common.c: In function =E2=80=98usbhs_pars= e_dt=E2=80=99: > >>>>> drivers/usb/renesas_usbhs/common.c:482:25: warning: cast from point= er to > >>>>> integer of different size [-Wpointer-to-int-cast] > >>>>> dparam->type =3D of_id ? (u32)of_id->data : 0; > >>>>> After looking into the function I am curious if the hardware is onl= y 32 bit as if > >>>>> the supported hardware for this driver is then this cast is no long= er required > >>>>> and I can send in a patch removing it. Furthermore, sorry for the s= imple > >>>>> question but I don't have access to the device specs for supported= hardware > >>>>> so I though it would be better to ask before I send in patch fixing= this issue. > >>>>> Thanks, > >>>>> Nick > >>>> > >>>> Patch is welcome, there will be comment if it is not suitable. > >>>> > >>>> Peter > >>>> > >>> I understand that,my question was does the hardware for this driver s= upport 64 bit. > >> > >> regardless, it shouldn't produce a build warning. > >> > > It does for me. > > Nick > >=20 > After looking more closely it seems me are trying to convert a const > void to a int. Does the data member need to be const as this may be > causing the issue. why would const have anything to do with sizes ? --=20 balbi --ftEhullJWpWg/VHq Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJVB6obAAoJEIaOsuA1yqRERnEQAJMAPeVrZ6SHXYXozClX4pQe M6EvE5907aBXfLOaP3OFZNVwpP6yPS5AnJfCBmxhLbudD8dUD0fecH2fcb3c4mB1 vHNEad8J3NCUQkF9Bvw5mAHQC/eE8XZGnWbc6h7jPSK/89QtJDy+fbzK1LdJKyEZ 0tEhaNuahLBtiJJNRYdjXYtQkQboaLoD9FbS1XOAsHRvVjBGCixM+j6AB65GwVrw 7fs0l1IRGQZz0ZMHb+P0yCKTMPARu4ceSBRyw7g+fhnXJrPTQvZoeMPEQU5QuZPR pPgeH4yLlZ6IFQDgZDqhwBnzqnuruYGZ3bNIF5EfebgEGwmitvdRcMP9nwctgRLg stwpdGba5+/LnZYrhpxFSiXyWYY+/qQjadzULAIclYVEgBu5QoTcAX2Ni8rYFWU0 26TV/2KAJBuYg6XDIaNaTSHXYgoPakTXemW/HZH7p6wrNvi1ydPNSAD9zGQh+td0 UJqKBQ5AUoOBOjivt/uX9eQ4uocyuBFEtN+hnkUNhEBfpSoFzFtH/mlx5aqqGZlo AEePEomSVxivrficvf+EaH2NpENLsMNWZAHi5Cdaa4xuSUj74E5W8F9rWzE/hDq/ 8U/FzXkaMg0tJg/UEBZZ/kjpj4qXL8lUPeYqL9xCQxSAmM0LE28W7uiLC2w3UYqP Nl7DzHLrj3lRGHbaBAa4 =/A9R -----END PGP SIGNATURE----- --ftEhullJWpWg/VHq--