From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932511AbbCQOLS (ORCPT <rfc822;w@1wt.eu>);
	Tue, 17 Mar 2015 10:11:18 -0400
Received: from smtprelay0047.hostedemail.com ([216.40.44.47]:47579 "EHLO
	smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
	by vger.kernel.org with ESMTP id S932138AbbCQOLQ (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 17 Mar 2015 10:11:16 -0400
X-Session-Marker: 726F737465647440676F6F646D69732E6F7267
X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::::::,RULES_HIT:41:355:379:541:599:800:960:968:973:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1539:1593:1594:1711:1730:1747:1777:1792:2198:2199:2393:2553:2559:2562:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3872:3873:3874:4362:5007:6261:7875:7903:10004:10400:10848:10967:11026:11232:11658:11914:12114:12517:12519:12740:13069:13311:13357:21080:21088,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0
X-HE-Tag: face49_4509d79cf3056
X-Filterd-Recvd-Size: 1834
Date: Tue, 17 Mar 2015 10:11:13 -0400
From: Steven Rostedt <rostedt@goodmis.org>
To: Christoph Lameter <cl@linux.com>
Cc: LKML <linux-kernel@vger.kernel.org>, Ingo Molnar <mingo@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>, "H. Peter Anvin" <hpa@zytor.com>,
        Uwe =?UTF-8?B?S2xlaW5lLUvDtm5pZw==?= 
	<u.kleine-koenig@pengutronix.de>,
        linux-arm-kernel@lists.infradead.org,
        Russell King <linux@arm.linux.org.uk>
Subject: Re: [RFC][PATCH] ring-buffer: Replace this_cpu_{read,write} with
 this_cpu_ptr()
Message-ID: <20150317101113.32f5618a@gandalf.local.home>
In-Reply-To: <20150317081341.0f9a8b4c@gandalf.local.home>
References: <20150316173154.537b80ee@gandalf.local.home>
	<alpine.DEB.2.11.1503170049300.9309@gentwo.org>
	<20150317081341.0f9a8b4c@gandalf.local.home>
X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 17 Mar 2015 08:13:41 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:

> > > I may go and remove all this_cpu_read,write() calls from my code
> > > because of this.
> > 
> > You could do that with __this_cpo_* but not this_cpu_*(). Doing
> > it to this_cpu_* would make the operations no longer per cpu atomic. If
> > they do not need per cpu atomicity then you could have used __this_cpu_*
> > instead. And  __this_cpu_* do not disable preemption or interrupts.
> 
> I do not need it to be atomic.

I test this out with __this_cpu_* versions and see if that solves it
too. If it does, I'll use that version instead.

Thanks,

-- Steve