From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754409AbbCQPg6 (ORCPT ); Tue, 17 Mar 2015 11:36:58 -0400 Received: from mail-wi0-f169.google.com ([209.85.212.169]:33448 "EHLO mail-wi0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753542AbbCQPg5 (ORCPT ); Tue, 17 Mar 2015 11:36:57 -0400 Date: Tue, 17 Mar 2015 16:36:54 +0100 From: Michal Hocko To: Vladimir Davydov Cc: Andrew Morton , Johannes Weiner , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] memcg: remove obsolete comment Message-ID: <20150317153654.GK28112@dhcp22.suse.cz> References: <1426606113-1694-1-git-send-email-vdavydov@parallels.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1426606113-1694-1-git-send-email-vdavydov@parallels.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue 17-03-15 18:28:33, Vladimir Davydov wrote: > Low and high watermarks, as they defined in the TODO to the mem_cgroup > struct, have already been implemented by Johannes, so remove the stale > comment. > > Signed-off-by: Vladimir Davydov Acked-by: Michal Hocko > --- > mm/memcontrol.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 0a06628470cc..74a9641d8f9f 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -259,11 +259,6 @@ static void mem_cgroup_oom_notify(struct mem_cgroup *memcg); > * page cache and RSS per cgroup. We would eventually like to provide > * statistics based on the statistics developed by Rik Van Riel for clock-pro, > * to help the administrator determine what knobs to tune. > - * > - * TODO: Add a water mark for the memory controller. Reclaim will begin when > - * we hit the water mark. May be even add a low water mark, such that > - * no reclaim occurs from a cgroup at it's low water mark, this is > - * a feature that will be implemented much later in the future. > */ > struct mem_cgroup { > struct cgroup_subsys_state css; > -- > 1.7.10.4 > -- Michal Hocko SUSE Labs